Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] client/benchmark #190

Merged
merged 1 commit into from
Mar 5, 2021
Merged

[Rename] client/benchmark #190

merged 1 commit into from
Mar 5, 2021

Conversation

adnapibar
Copy link
Contributor

*Issue #160 *

Description of changes:

Rename in the client/benchmark directory.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Rabi Panda adnapibar@gmail.com

@adnapibar adnapibar added >FORK Related to the fork process Rename Renaming to OpenSearch labels Mar 3, 2021
This PR renames Elasticsearch to OpenSearch in the client/benchmark module.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@odfe-release-bot
Copy link

Request for Admin to accept this test.

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's figure out what to do about the geonames corpus reference in the README. Maybe just open an issue?

Other changes LGTM!

@@ -21,7 +21,7 @@ In general, you should define a few GC-related settings `-Xms8192M -Xmx8192M -XX

#### Bulk indexing

Download benchmark data from http://benchmarks.elasticsearch.org.s3.amazonaws.com/corpora/geonames and decompress them.
Download benchmark data from http://benchmarks.opensearch.org.s3.amazonaws.com/corpora/geonames and decompress them.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably take a note about this? This will 404 atm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! have created the issue #211

@adnapibar adnapibar merged commit d7bf93e into opensearch-project:rename/opensearch Mar 5, 2021
@adnapibar adnapibar deleted the rename/client/benchmark branch March 5, 2021 05:42
nknize pushed a commit that referenced this pull request Mar 22, 2021
This PR renames Elasticsearch to OpenSearch in the client/benchmark module.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>FORK Related to the fork process Rename Renaming to OpenSearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants