[plugin] repository-azure: add configuration settings for connect/write/response/read timeouts #1789
Conversation
…te/response/read timeouts Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
It's probably worth adding a comment to the existing timeout setting to explain what it means now that there are additional timeout settings.
| // See please NettyAsyncHttpClientBuilder#DEFAULT_CONNECT_TIMEOUT | ||
| public static final AffixSetting<TimeValue> CONNECTION_TIMEOUT_SETTING = Setting.affixKeySetting( | ||
| AZURE_CLIENT_PREFIX_KEY, | ||
| "connection.timeout", |
There was a problem hiding this comment.
Minor, but what do you think about using "connect" instead of "connection" for this setting and the variable names to keep it consistent with the underlying Azure property?
There was a problem hiding this comment.
@andrross thank you, sure, no objections, renaming
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
I think the official docs for each plugin is the best way to describe the settings, but comment has been added |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…te/response/read timeouts (opensearch-project#1789) * [plugin] repository-azure: add configuration settings for connect/write/response/read timeouts Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Addressing code review comments: renaming connectionXxx to connectXxx Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Addressing code review comments: adding timeout comment Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…te/response/read timeouts (#1789) (#1802) * [plugin] repository-azure: add configuration settings for connect/write/response/read timeouts Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Addressing code review comments: renaming connectionXxx to connectXxx Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Addressing code review comments: adding timeout comment Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
The Azure Repository Plugin supports only single timeout setting which translates to operation timeout in Azure SDK v12. However, there are connect/write/response/read timeouts which could be fine tuned for a particular environment but there is no convenient way to configure those right now.
The following new settings have been introduced:
Issues Resolved
Closes #1762
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.