Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FORWARDPORT 2.x] Add 2.19 release notes #17302

Merged

Conversation

jainankitk
Copy link
Collaborator

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ankit Jain <akjain@amazon.com>
@jainankitk
Copy link
Collaborator Author

@reta - I am confused while forward porting to main. For example:

Why the CHANGELOG.md entry - Latency and Memory allocation improvements to Multi Term Aggregation queries (#14993) is not there in 2.x branch. As per my understanding, if it is not relevant for 2.x, should have been part of CHANGELOG-3.0.md?

@reta
Copy link
Collaborator

reta commented Feb 7, 2025

@reta - I am confused while forward porting to main. For example:

@jainankitk seems like backport has failed [1] and no one took any actions :(

[1] #14993 (comment)

@jainankitk
Copy link
Collaborator Author

@reta - I am confused while forward porting to main. For example:

@jainankitk seems like backport has failed [1] and no one took any actions :(

[1] #14993 (comment)

There is possibility of unliked PR, but given changelog is missing in 2.x, chances are low. So, from the release notes perspective, main CHANGELOG.md should be exactly same as 2.x, except if there are commits in the meantime. Anything meant for 3.x only, should just be part of CHANGELOG-3.0.md

@reta
Copy link
Collaborator

reta commented Feb 7, 2025

So, from the release notes perspective, main CHANGELOG.md should be exactly same as 2.x, except if there are commits in the meantime.

Correct, if backport was done (manually or automatically)

Anything meant for 3.x only, should just be part of CHANGELOG-3.0.md

Correct

@jainankitk jainankitk merged commit a31b5e3 into opensearch-project:2.x Feb 7, 2025
66 checks passed
@jainankitk jainankitk deleted the release-notes-2.19-on-2.x branch February 7, 2025 23:26
@jainankitk
Copy link
Collaborator Author

main: #17317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants