-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] ElasticsearchStatusException in server module #172
Merged
nknize
merged 4 commits into
opensearch-project:rename/opensearch
from
nknize:rename/server/ElasticsearchStatusException
Mar 3, 2021
Merged
[Rename] ElasticsearchStatusException in server module #172
nknize
merged 4 commits into
opensearch-project:rename/opensearch
from
nknize:rename/server/ElasticsearchStatusException
Mar 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the ElasticsearchStatusException in the server module to OpenSearchStatusException. References and usages throughout the rest of the codebase are fully refactored. Signed-off-by: Nicholas Knize <nknize@amazon.com>
nknize
commented
Mar 3, 2021
server/src/test/java/org/elasticsearch/rest/BytesRestResponseTests.java
Outdated
Show resolved
Hide resolved
adnapibar
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment otherwise LGTM.
Response response = responseException.getResponse(); | ||
HttpEntity entity = response.getEntity(); | ||
ElasticsearchStatusException elasticsearchException; | ||
OpenSearchStatusException elasticsearchException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
variable name rename?
…usException Signed-off-by: Nicholas Knize <nknize@amazon.com>
nknize
force-pushed
the
rename/server/ElasticsearchStatusException
branch
from
March 3, 2021 22:58
1eada6c
to
2bb139b
Compare
Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Nicholas Knize <nknize@amazon.com>
nknize
added a commit
that referenced
this pull request
Mar 22, 2021
This commit refactors the ElasticsearchStatusException in the server module to OpenSearchStatusException. References and usages throughout the rest of the codebase are fully refactored. Signed-off-by: Nicholas Knize <nknize@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the ElasticsearchStatusException in the server module to
OpenSearchStatusException. References and usages throughout the rest of the
codebase are fully refactored.
relates #160