Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Star Tree] [Search] Resolving Date histogram with metric aggregation using star-tree #17163

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[Backport 2.x] [Star Tree] [Search] Resolving Date histogram with metric aggregation using star-tree #17163

merged 1 commit into from
Jan 28, 2025

Conversation

sandeshkr419
Copy link
Contributor

@sandeshkr419 sandeshkr419 commented Jan 28, 2025 •
edited
Loading

Description

Backport #17150 to 2.x

(automatic backport failed)

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sandeshkr419 sandeshkr419 mentioned this pull request Jan 28, 2025
Closed
@sandeshkr419 sandeshkr419 changed the title [Backport 2.x] [Star Tree] [Search] Resolve Date histogram with metri… [Backport 2.x] [Star Tree] [Search] Resolving Date histogram with metric aggregation using star-tree Jan 28, 2025
@sandeshkr419
[Backport 2.x] [Star Tree] [Search] Resolve Date histogram with metri…
ad74278 
…c aggregation using star-tree (opensearch-project#16674)

---------

Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
@sandeshkr419 sandeshkr419 added v2.19.0 Issues and PRs related to version 2.19.0 enhancement Enhancement or improvement to existing feature or request labels Jan 28, 2025
@sandeshkr419 sandeshkr419 self-assigned this Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ad74278: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ad74278: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ad74278: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for ad74278: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.91228% with 23 lines in your changes missing coverage. Please review.

Project coverage is 71.98%. Comparing base (1c7f719) to head (ad74278).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ions/bucket/histogram/DateHistogramAggregator.java 87.50% 2 Missing and 6 partials ⚠️
...x/datacube/startree/utils/StarTreeQueryHelper.java 90.56% 0 Missing and 5 partials ⚠️
...rch/search/aggregations/metrics/AvgAggregator.java 84.37% 1 Missing and 4 partials ⚠️
...rch/search/aggregations/metrics/MaxAggregator.java 90.00% 0 Missing and 1 partial ⚠️
...rch/search/aggregations/metrics/MinAggregator.java 88.88% 0 Missing and 1 partial ⚠️
...rch/search/aggregations/metrics/SumAggregator.java 94.11% 0 Missing and 1 partial ⚠️
...rch/aggregations/metrics/ValueCountAggregator.java 83.33% 0 Missing and 1 partial ⚠️
...org/opensearch/search/startree/StarTreeFilter.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17163      +/-   ##
============================================
+ Coverage     71.89%   71.98%   +0.08%     
- Complexity    65852    65895      +43     
============================================
  Files          5332     5333       +1     
  Lines        306587   306782     +195     
  Branches      44720    44752      +32     
============================================
+ Hits         220429   220844     +415     
+ Misses        67754    67475     -279     
- Partials      18404    18463      +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mch2 mch2 merged commit 2406319 into opensearch-project:2.x Jan 28, 2025
55 checks passed
This was referenced Jan 29, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees

@sandeshkr419 sandeshkr419

Labels
enhancement Enhancement or improvement to existing feature or request Search:Aggregations v2.19.0 Issues and PRs related to version 2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandeshkr419 @mch2