[Rename] ElasticsearchParseException class in server module #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors ElasticsearchParseException class in the server module to OpenSearchParseException. References and usages throughout the rest of the codebase are fully refactored. Signed-off-by: Nicholas Knize <nknize@amazon.com>
…eException Signed-off-by: Nicholas Knize <nknize@amazon.com>
Signed-off-by: Nicholas Knize <nknize@amazon.com>
|
Request for Admin to accept this test. |
adnapibar
approved these changes
Mar 4, 2021
...est-common/src/internalClusterTest/java/org/elasticsearch/ingest/common/IngestRestartIT.java
Outdated
Show resolved
Hide resolved
| @@ -799,8 +799,8 @@ public String toString() { | |||
| org.elasticsearch.indices.IndexPrimaryShardNotAllocatedException::new, 33, UNKNOWN_VERSION_ADDED), | |||
| TRANSPORT_EXCEPTION(org.elasticsearch.transport.TransportException.class, | |||
| org.elasticsearch.transport.TransportException::new, 34, UNKNOWN_VERSION_ADDED), | |||
| ELASTICSEARCH_PARSE_EXCEPTION(org.elasticsearch.ElasticsearchParseException.class, | |||
| org.elasticsearch.ElasticsearchParseException::new, 35, UNKNOWN_VERSION_ADDED), | |||
| ELASTICSEARCH_PARSE_EXCEPTION(org.elasticsearch.OpenSearchParseException.class, | |||
There was a problem hiding this comment.
Are we renaming the enums as part of a separate PR?
There was a problem hiding this comment.
Yeah, I think at this point making a separate sweeping rename PR is the right move
Signed-off-by: Nicholas Knize <nknize@amazon.com>
nknize
added a commit
that referenced
this pull request
Mar 22, 2021
This commit refactors ElasticsearchParseException class in the server module to OpenSearchParseException. References and usages throughout the rest of the codebase are fully refactored. Signed-off-by: Nicholas Knize <nknize@amazon.com>
ritty27
pushed a commit
to ritty27/OpenSearch
that referenced
this pull request
May 12, 2024
…project#169) Signed-off-by: Rene Cordier <rcordier@linagora.com>
ritty27
pushed a commit
to ritty27/OpenSearch
that referenced
this pull request
May 12, 2024
* Sort field in Hit deserializer should handle null events (opensearch-project#169) Signed-off-by: Rene Cordier <rcordier@linagora.com> Signed-off-by: Matt Timmermans <mtimmermans@tripadvisor.com> * Deprecating master terminology to support inclusive naming (opensearch-project#167) * Deprecating master terminology to support inclusive naming Signed-off-by: Vacha Shah <vachshah@amazon.com> * Fixing tests against unreleased OpenSearch Signed-off-by: Vacha Shah <vachshah@amazon.com> Signed-off-by: Matt Timmermans <mtimmermans@tripadvisor.com> * Fix issue 172 Signed-off-by: Matt Timmermans <mtimmermans@tripadvisor.com> * Add test for issue 172 Signed-off-by: Matt Timmermans <mtimmermans@tripadvisor.com> Co-authored-by: Rene Cordier <rene.cordier@gmail.com> Co-authored-by: Vacha Shah <vachshah@amazon.com> Co-authored-by: Matt Timmermans <mtimmermans@tripadvisor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors ElasticsearchParseException class in the server module to
OpenSearchParseException. References and usages throughout the rest of the
codebase are fully refactored.
relates #160