Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify precomputation of aggregations behind a common API #16733

Merged
merged 5 commits into from
Jan 30, 2025

Add comment as suggested by @bowenlan-amzn

1c3c990
Select commit
Loading
Failed to load commit list.
Merged

Unify precomputation of aggregations behind a common API #16733

Add comment as suggested by @bowenlan-amzn
1c3c990
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 30, 2025 in 0s

82.05% of diff hit (target 72.41%)

View this Pull Request on Codecov

82.05% of diff hit (target 72.41%)

Annotations

Check warning on line 171 in server/src/main/java/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java#L171

Added line #L171 was not covered by tests

Check warning on line 447 in server/src/main/java/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/aggregations/bucket/terms/GlobalOrdinalsStringTermsAggregator.java#L447

Added line #L447 was not covered by tests

Check warning on line 115 in server/src/main/java/org/opensearch/search/aggregations/metrics/AvgAggregator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/aggregations/metrics/AvgAggregator.java#L115

Added line #L115 was not covered by tests

Check warning on line 117 in server/src/main/java/org/opensearch/search/aggregations/metrics/MaxAggregator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/aggregations/metrics/MaxAggregator.java#L117

Added line #L117 was not covered by tests

Check warning on line 110 in server/src/main/java/org/opensearch/search/aggregations/metrics/MinAggregator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/aggregations/metrics/MinAggregator.java#L110

Added line #L110 was not covered by tests

Check warning on line 117 in server/src/main/java/org/opensearch/search/aggregations/metrics/MinAggregator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/aggregations/metrics/MinAggregator.java#L117

Added line #L117 was not covered by tests

Check warning on line 105 in server/src/main/java/org/opensearch/search/aggregations/metrics/SumAggregator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/aggregations/metrics/SumAggregator.java#L105

Added line #L105 was not covered by tests

Check warning on line 98 in server/src/main/java/org/opensearch/search/aggregations/metrics/ValueCountAggregator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/aggregations/metrics/ValueCountAggregator.java#L98

Added line #L98 was not covered by tests

Check warning on line 110 in server/src/main/java/org/opensearch/search/aggregations/metrics/ValueCountAggregator.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/org/opensearch/search/aggregations/metrics/ValueCountAggregator.java#L110

Added line #L110 was not covered by tests