Add ITs for disallow repo settings update during repo in use #16001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
ashking94
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16001 +/- ##
============================================
+ Coverage 71.90% 71.95% +0.04%
+ Complexity 64392 64364 -28
============================================
Files 5278 5280 +2
Lines 300877 300872 -5
Branches 43478 43477 -1
============================================
+ Hits 216351 216484 +133
+ Misses 66747 66590 -157
- Partials 17779 17798 +19 ☔ View full report in Codecov by Sentry. |
gbbafna
approved these changes
Sep 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 21, 2024
Signed-off-by: Ashish Singh <ssashish@amazon.com> (cherry picked from commit 036f6bc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amberzsy
pushed a commit
to amberzsy/OpenSearch-public
that referenced
this pull request
Sep 22, 2024
…-project#16001) Signed-off-by: Ashish Singh <ssashish@amazon.com>
ruai0511
pushed a commit
to ruai0511/OpenSearch
that referenced
this pull request
Oct 4, 2024
…-project#16001) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
…-project#16001) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
…-project#16001) Signed-off-by: Ashish Singh <ssashish@amazon.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
…-project#16001) Signed-off-by: Ashish Singh <ssashish@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Jan 21, 2025
…-project#16001) Signed-off-by: Ashish Singh <ssashish@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we are adding integration tests that checks that updating repository settings fail if the repository is in use - create snapshot or delete snapshots are ongoing.
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.