Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate translog cleanup with snapshot deletion and fix primary term deletion logic #15657

Merged
merged 6 commits into from
Sep 4, 2024

Fix tests

8663344
Select commit
Loading
Failed to load commit list.
Merged

Integrate translog cleanup with snapshot deletion and fix primary term deletion logic #15657

Fix tests
8663344
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 4, 2024 in 0s

71.95% (target 70.00%)

View this Pull Request on Codecov

71.95% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 40.62500% with 76 lines in your changes missing coverage. Please review.

Project coverage is 71.95%. Comparing base (71a771e) to head (8663344).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...index/translog/RemoteFsTimestampAwareTranslog.java 40.00% 44 Missing and 1 partial ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 0.00% 19 Missing ⚠️
...ex/translog/transfer/TranslogTransferMetadata.java 67.85% 6 Missing and 3 partials ⚠️
...dex/translog/transfer/TranslogTransferManager.java 50.00% 1 Missing and 1 partial ⚠️
...ndex/store/RemoteSegmentStoreDirectoryFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15657      +/-   ##
============================================
+ Coverage     71.85%   71.95%   +0.09%     
- Complexity    64077    64123      +46     
============================================
  Files          5269     5269              
  Lines        299880   299991     +111     
  Branches      43343    43356      +13     
============================================
+ Hits         215477   215853     +376     
+ Misses        66679    66381     -298     
- Partials      17724    17757      +33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov