Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RW Separation] Add routing preference to route requests only to search replicas. #15563

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Sep 2, 2024

Description

This adds SEARCH_REPLICA routing preference and defaults to this preference for indices that have them.

Related Issues

Resolves #15562

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This adds SEARCH_REPLICA routing preference and defaults to this preference
for indices that have search replicas.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@mch2 mch2 changed the title Add routing preference to route requests only to search replicas. [RW Separation] Add routing preference to route requests only to search replicas. Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for 72312a1: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@mch2 mch2 added the backport 2.x Backport to 2.x branch label Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for bb19dc2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for 72312a1: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for fced109: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❕ Gradle check result for aac9334: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=snapshot.status/10_basic/Get snapshot status}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (e087272) to head (268535a).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...g/opensearch/cluster/routing/OperationRouting.java 66.66% 0 Missing and 2 partials ⚠️
...search/cluster/routing/IndexShardRoutingTable.java 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15563      +/-   ##
============================================
- Coverage     72.00%   71.90%   -0.11%     
+ Complexity    64149    64123      -26     
============================================
  Files          5269     5269              
  Lines        299834   299878      +44     
  Branches      43330    43344      +14     
============================================
- Hits         215895   215623     -272     
- Misses        66217    66447     +230     
- Partials      17722    17808      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment was marked as outdated.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
@mch2
Copy link
Member Author

mch2 commented Sep 4, 2024

removed changelog entry here to reduce all the backport / gc pain, will include 1 entry for all the separation prs and link to the design issue.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for 268535a: SUCCESS

@mch2 mch2 merged commit 3681b52 into opensearch-project:main Sep 4, 2024
36 of 38 checks passed
@mch2 mch2 deleted the alloc-routing branch September 4, 2024 19:17
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
…ch replicas. (#15563)

* Add routing preference to route requests only to search replicas.

This adds SEARCH_REPLICA routing preference and defaults to this preference
for indices that have search replicas.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* add changelog entry

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* PR feedback - extract a private method for replica filtering

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* remove changelog entry

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

---------

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
(cherry picked from commit 3681b52)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2 pushed a commit that referenced this pull request Sep 4, 2024
…ch replicas. (#15563) (#15690)

* Add routing preference to route requests only to search replicas.

This adds SEARCH_REPLICA routing preference and defaults to this preference
for indices that have search replicas.



* add changelog entry



* PR feedback - extract a private method for replica filtering



* remove changelog entry



---------


(cherry picked from commit 3681b52)

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
…ch replicas. (#15563) (#15690)

* Add routing preference to route requests only to search replicas.

This adds SEARCH_REPLICA routing preference and defaults to this preference
for indices that have search replicas.

* add changelog entry

* PR feedback - extract a private method for replica filtering

* remove changelog entry

---------

(cherry picked from commit 3681b52)

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit b787753)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2 pushed a commit that referenced this pull request Sep 4, 2024
…ch replicas. (#15563) (#15690) (#15699)

* Add routing preference to route requests only to search replicas.

This adds SEARCH_REPLICA routing preference and defaults to this preference
for indices that have search replicas.

* add changelog entry

* PR feedback - extract a private method for replica filtering

* remove changelog entry

---------

(cherry picked from commit 3681b52)




(cherry picked from commit b787753)

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
…ch replicas. (opensearch-project#15563)

* Add routing preference to route requests only to search replicas.

This adds SEARCH_REPLICA routing preference and defaults to this preference
for indices that have search replicas.

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* add changelog entry

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* PR feedback - extract a private method for replica filtering

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

* remove changelog entry

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>

---------

Signed-off-by: Marc Handalian <marc.handalian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a routing preference to route searches to search replicas
2 participants