Compare numbers with equals() instead of == #15366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
dk2k
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15366 +/- ##
============================================
- Coverage 71.93% 71.82% -0.11%
+ Complexity 63223 63172 -51
============================================
Files 5214 5214
Lines 295938 295938
Branches 42754 42754
============================================
- Hits 212876 212564 -312
- Misses 65601 65949 +348
+ Partials 17461 17425 -36 ☔ View full report in Codecov by Sentry. |
dblock
approved these changes
Aug 23, 2024
|
@dk2k Maybe gather these PRs into one? |
dbwiddis
approved these changes
Aug 25, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 25, 2024
Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> (cherry picked from commit f195285) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
pushed a commit
that referenced
this pull request
Aug 26, 2024
(cherry picked from commit f195285) Signed-off-by: Dmitry Kryukov <dk2k@ya.ru> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
dk2k
added a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
dk2k
added a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
dk2k
added a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Dmitry Kryukov <dk2k@ya.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare numbers with equals() instead of ==