-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve breaking change logic for changelog verifier #15214
Conversation
❌ Gradle check result for 5b0d901: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Jay Deng <jayd0104@gmail.com>
@andrross @sandeshkr419 could you help review? Thanks! |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15214-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2defb76f8bb0d53714804963b5f155730a1825d8
# Push it to GitHub
git push --set-upstream origin backport/backport-15214-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@jed326 Can you look into what change wasn't backported and then retrigger this workflow once that's done? |
Thanks @peternied, I realized that we probably don't want to backport this since changelog-3.0 doesn't exist on 2.x branch |
…ect#15214) Signed-off-by: Jay Deng <jayd0104@gmail.com>
…ect#15214) Signed-off-by: Jay Deng <jayd0104@gmail.com>
Description
Improve breaking change logic for changelog verifier
Related Issues
Check List
- [ ] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.