Optimise unassigned shards iteration after allocator timeout #14977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
imRishN
added
skip-changelog
and removed
bug
imRishN
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for fad910e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
rajiv-kv
reviewed
Aug 2, 2024
server/src/main/java/org/opensearch/gateway/ShardsBatchGatewayAllocator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
|
❌ Gradle check result for 3cfa046: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 3a80281: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
|
❕ Gradle check result for 9aee4e9: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Bukhtawar
approved these changes
Aug 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
* Optimise unassigned shards iteration after allocator timeout Signed-off-by: Rishab Nahata <rnnahata@amazon.com> (cherry picked from commit 555a56d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
…rch-project#14977) * Optimise unassigned shards iteration after allocator timeout Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…rch-project#14977) * Optimise unassigned shards iteration after allocator timeout Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
imRishN
added a commit
to imRishN/OpenSearch
that referenced
this pull request
Sep 4, 2024
…rch-project#14977) * Optimise unassigned shards iteration after allocator timeout Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
imRishN
added a commit
to imRishN/OpenSearch
that referenced
this pull request
Sep 4, 2024
…rch-project#14977) * Optimise unassigned shards iteration after allocator timeout Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
…rch-project#14977) * Optimise unassigned shards iteration after allocator timeout Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimises on how shards are marked throttled once it is timed out. Earlier it use to iterate over all unassigned shards for every batch, now it would collect all the shards that needs to ignored at once and iterate over unassigned shards once.
Related Issues
Resolves #14944
Check List
[] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.