Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route search traffic to _primary_first for warm index #14934

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

neetikasinghal
Copy link
Contributor

@neetikasinghal neetikasinghal commented Jul 23, 2024

Description

Route search traffic to _primary_first for warm index

Related Issues

Resolves #14543

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Copy link
Contributor

❕ Gradle check result for 26d05fa: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.85%. Comparing base (087355f) to head (26d05fa).

Files Patch % Lines
...g/opensearch/cluster/routing/OperationRouting.java 60.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14934      +/-   ##
============================================
+ Coverage     71.79%   71.85%   +0.05%     
- Complexity    62598    62665      +67     
============================================
  Files          5159     5159              
  Lines        294036   294041       +5     
  Branches      42515    42518       +3     
============================================
+ Hits         211104   211282     +178     
+ Misses        65528    65370     -158     
+ Partials      17404    17389      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jed326 jed326 removed v2.16.0 Issues and PRs related to version 2.16.0 backport 2.16 labels Jul 30, 2024
@jed326 jed326 merged commit 0324edd into opensearch-project:main Jul 31, 2024
74 of 80 checks passed
@jed326 jed326 added backport 2.16 v2.16.0 Issues and PRs related to version 2.16.0 labels Jul 31, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 31, 2024
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
(cherry picked from commit 0324edd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 31, 2024
Signed-off-by: Neetika Singhal <neetiks@amazon.com>
(cherry picked from commit 0324edd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the Storage Issues and PRs relating to data and metadata storage label Jul 31, 2024
@neetikasinghal neetikasinghal deleted the tiering-pp branch July 31, 2024 19:14
@jed326 jed326 added v2.17.0 backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch v2.16.0 Issues and PRs related to version 2.16.0 backport 2.16 labels Jul 31, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14934-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0324edda286a2ab8a795d7f86b3402d229cd2255
# Push it to GitHub
git push --set-upstream origin backport/backport-14934-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-14934-to-2.x.

jed326 pushed a commit that referenced this pull request Jul 31, 2024
(cherry picked from commit 0324edd)

Signed-off-by: Neetika Singhal <neetiks@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Aug 20, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed release skip-changelog Storage Issues and PRs relating to data and metadata storage v2.17.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Add primary preference to be set as an index setting for the warm index
3 participants