-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling spotless, disabling checkstyle check on plugins #1488
Conversation
:plugins:mapper-annotated-text :plugins:mapper-murmur3 :plugins:mapper-size :plugins:repository-azure :plugins:repository-gcs :plugins:repository-hdfs :plugins:repository-s3 :plugins:store-smb :plugins:transport-nio :qa:die-with-dignity Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
start gradle check |
Can one of the admins verify this patch? |
✅ Gradle Wrapper Validation success 1bf4745 |
Signed-off-by: Himanshu Setia <setiah@amazon.com>
✅ Gradle Wrapper Validation success e57bbd1 |
✅ Gradle Precommit success 1bf4745 |
✅ Gradle Precommit success e57bbd1 |
start gradle check |
':plugins:transport-nio', | ||
':qa:die-with-dignity' | ||
] | ||
def projectPathsToExclude = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally! 😁
Signed-off-by: Himanshu Setia <setiah@amazon.com>
start gradle check |
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia setiah@amazon.com
Description
This change enables spotless check and reformats plugins as per spotlessApply style.
Issues Resolved
#974
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.