Enabling spotless, disabling checkstyle check on plugins #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 27, 2021 20:05
:plugins:mapper-annotated-text :plugins:mapper-murmur3 :plugins:mapper-size :plugins:repository-azure :plugins:repository-gcs :plugins:repository-hdfs :plugins:repository-s3 :plugins:store-smb :plugins:transport-nio :qa:die-with-dignity Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Signed-off-by: Himanshu Setia <setiah@amazon.com>
|
start gradle check |
|
Can one of the admins verify this patch? |
|
✅ Gradle Wrapper Validation success 1bf4745 |
Signed-off-by: Himanshu Setia <setiah@amazon.com>
|
✅ Gradle Wrapper Validation success e57bbd1 |
|
✅ Gradle Precommit success 1bf4745 |
|
✅ Gradle Precommit success e57bbd1 |
|
start gradle check |
| ':plugins:transport-nio', | ||
| ':qa:die-with-dignity' | ||
| ] | ||
| def projectPathsToExclude = [] |
saratvemulapalli
approved these changes
Nov 2, 2021
setiah
pushed a commit
to setiah/OpenSearch
that referenced
this pull request
Nov 2, 2021
Signed-off-by: Himanshu Setia <setiah@amazon.com>
owaiskazi19
approved these changes
Nov 2, 2021
|
start gradle check |
5 tasks
saratvemulapalli
pushed a commit
that referenced
this pull request
Nov 2, 2021
Signed-off-by: Himanshu Setia <setiah@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Himanshu Setia setiah@amazon.com
Description
This change enables spotless check and reformats plugins as per spotlessApply style.
Issues Resolved
#974
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.