Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize _cat/nodes api #14853

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

optimize _cat/nodes api #14853

wants to merge 1 commit into from
+605 −48

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Jul 22, 2024 •
edited
Loading

Description

Optimize the api _cat/nodes

Related Issues

Resolves #14746

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added Cluster Manager enhancement Enhancement or improvement to existing feature or request labels Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for fa803c8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ed82093: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the optimize_nodes_api branch 2 times, most recently from ea17600 to ae434b9 Compare July 22, 2024 09:25
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ea17600: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ae434b9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dblock
dblock requested changes Jul 22, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please describe why this is an improvement. Maybe add a micro-benchmark?

qa/smoke-test-http/src/test/java/org/opensearch/http/HttpCatIT.java Outdated Show resolved Hide resolved
server/src/main/resources/org/opensearch/bootstrap/test-framework.policy Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/rest/action/cat/RestNodesAction.java Outdated Show resolved Hide resolved
This was referenced Sep 9, 2024
Open
Open
Open
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7dae6e6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 11, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 66b38d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 13, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e064f26: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 668276e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2aa4b8d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 7d42245: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.indices.state.CloseWhileRelocatingShardsIT.testCloseWhileRelocatingShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@kkewwei
Copy link
Contributor Author

kkewwei commented Sep 16, 2024

@aasom143, please have a look when you are free.

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 19, 2024
Open
@kkewwei
Cancellation support for cat/nodes and optimize it
c7049f8 
Signed-off-by: kkewwei <kkewwei@163.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c7049f8: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei
Copy link
Contributor Author

kkewwei commented Sep 21, 2024

@msfroh I have a little doubt, please help confirm when you are free:

  1. If we just support object value in flat_object field, do we need to support null_value?
  2. If we do, does our null_value must be an object field?

This was referenced Sep 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock requested changes

@Bukhtawar Bukhtawar Bukhtawar left review comments

@sandeshkr419 sandeshkr419 sandeshkr419 left review comments

@aasom143 aasom143 aasom143 left review comments

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Cluster Manager enhancement Enhancement or improvement to existing feature or request
Projects
Cluster Manager Project Board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Optimize the api _cat/nodes
7 participants
@kkewwei @dblock @mgodwan @aasom143 @shwetathareja @Bukhtawar @sandeshkr419