[Backport] [2.x] Allow @InternalApi annotation on classes not meant to be constructed outside of the OpenSearch core (#14575) #14579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…outside of the OpenSearch core (opensearch-project#14575) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 391dee2)
reta
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #14579 +/- ##
============================================
- Coverage 71.39% 71.37% -0.02%
- Complexity 62268 62293 +25
============================================
Files 5102 5102
Lines 293130 293146 +16
Branches 42715 42716 +1
============================================
- Hits 209275 209245 -30
- Misses 66203 66331 +128
+ Partials 17652 17570 -82 ☔ View full report in Codecov by Sentry. |
andrross
approved these changes
Jun 27, 2024
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…outside of the OpenSearch core (opensearch-project#14575) (opensearch-project#14579) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 391dee2) Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14575 to
2.x