Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] SymbolicLinkPreservingUntarTransform fails on Windows #1433

Merged
merged 1 commit into from
Oct 26, 2021
Merged

[BUG] SymbolicLinkPreservingUntarTransform fails on Windows #1433

merged 1 commit into from
Oct 26, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 25, 2021

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

When building distribution on Windows, the ./gradle assemble task fails on attempt to build Linux/MacOS distributions. The cause was identified (see please #1430) and after discussion with @dblock , we have concluded that the best plan for action in this case is to build only Windows distributions on Windows platform.

The Docker images building task is also impacted since it reuses the Linux-based distributions in order to prepare the images. Since those are not built anymore on Windows, its execution becomes conditional.

$  ./gradlew assemble
...

Skipping task linuxArm64Tar since it does not match current OS platform
Skipping task linuxTar since it does not match current OS platform
Skipping task darwinTar since it does not match current OS platform
Skipping task darwinTar since it does not match current OS platform
Skipping task freebsdTar since it does not match current OS platform
Skipping task freebsdTar since it does not match current OS platform
Skipping task linuxArm64Tar since it does not match current OS platform
Skipping task linuxTar since it does not match current OS platform
Skipping task noJdkDarwinTar since it does not match current OS platform
Skipping task noJdkDarwinTar since it does not match current OS platform
Skipping task noJdkFreebsdTar since it does not match current OS platform
Skipping task noJdkFreebsdTar since it does not match current OS platform
Skipping task noJdkLinuxTar since it does not match current OS platform
Skipping task noJdkLinuxTar since it does not match current OS platform

...

BUILD SUCCESSFUL in 2m 40s
782 actionable tasks: 781 executed, 1 up-to-date

Issues Resolved

Fixes #1430

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 4eb348a415f735d4b2f1c6cd860a8e0659ec6c13

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 4eb348a415f735d4b2f1c6cd860a8e0659ec6c13

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Precommit failure 4eb348a415f735d4b2f1c6cd860a8e0659ec6c13
Log 1391

@reta
[BUG] SymbolicLinkPreservingUntarTransform fails on Windows
009a089 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 009a089

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 009a089

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 009a089

@dblock
Copy link
Member

dblock commented Oct 26, 2021

start gradle check

dblock
dblock approved these changes Oct 26, 2021
View reviewed changes
...Src/src/main/java/org/opensearch/gradle/internal/InternalDistributionArchiveSetupPlugin.java
if (OperatingSystem.current().isWindows()) {
// On Windows, include only Windows distributions and integTestZip
final String nameLowerCased = name.toLowerCase();
final boolean skip = !(nameLowerCased.contains("windows") || nameLowerCased.contains("integtest"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gross, but I will take it

Copy link
Collaborator Author

@reta reta Oct 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to handle it better, we have only compound name like freebsdTar, linuxArm64Tar, ... , to make it a bit cleaner we could skip integtestZip fe (I don't think this is a big deal), what do you think?

final boolean skip = !nameLowerCased.contains("windows");

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 009a089
Log 811

Reports 811

@dblock dblock merged this pull request into opensearch-project:main Oct 26, 2021
@dblock dblock added the pending backport Identifies an issue or PR that still needs to be backported label Oct 26, 2021
@reta
Copy link
Collaborator Author

reta commented Oct 26, 2021

@dblock thanks for merging, do you have a chance to verify ./gradlew assemble independently on your Windows box(es)? I certainly did it a number of time, but would be great to confirm, thank you!

reta added a commit to reta/OpenSearch that referenced this pull request Oct 26, 2021
@reta
[BUG] SymbolicLinkPreservingUntarTransform fails on Windows (opensea…
f5bbd55 
…rch-project#1433)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta mentioned this pull request Oct 26, 2021
Merged
5 tasks
nknize pushed a commit that referenced this pull request Oct 26, 2021
@reta @nknize
[BUG] SymbolicLinkPreservingUntarTransform fails on Windows (#1433)
f469d53 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@dblock
Copy link
Member

dblock commented Oct 26, 2021

@reta worked on my machine

distribution/archives/no-jdk-windows-zip/build/distributions/opensearch-min-2.0.0-SNAPSHOT-no-jdk-windows-x64.zip
distribution/archives/windows-zip/build/distributions/opensearch-min-2.0.0-SNAPSHOT-windows-x64.zip

Thanks a lot for this!

dblock pushed a commit that referenced this pull request Oct 26, 2021
@reta
[BUG] SymbolicLinkPreservingUntarTransform fails on Windows (#1433) (#…
6cfd8af 
…1439)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@nknize nknize added bug Something isn't working cicd v2.0.0 Version 2.0.0 and removed pending backport Identifies an issue or PR that still needs to be backported labels Oct 28, 2021
@reta reta mentioned this pull request May 2, 2022
Open
@mch2 mch2 mentioned this pull request Nov 1, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cicd v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] SymbolicLinkPreservingUntarTransform fails on Windows
4 participants
@reta @opensearch-ci-bot @dblock @nknize