Revert "[Remote Store] Fix sleep time bug during remote store sync (#… #14274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#14037)" This reverts commit afeddc2. Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
github-actions
bot
added
bug
reta
approved these changes
Jun 13, 2024
|
❌ Gradle check result for 2699ce4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 30aac19: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14274 +/- ##
============================================
+ Coverage 71.42% 71.68% +0.26%
- Complexity 59978 62045 +2067
============================================
Files 4985 5117 +132
Lines 282275 291688 +9413
Branches 40946 42167 +1221
============================================
+ Hits 201603 209096 +7493
- Misses 63999 65351 +1352
- Partials 16673 17241 +568 ☔ View full report in Codecov by Sentry. |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14274-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 71dbc22da2bde2af9786eb47943400e98bad7cbe
# Push it to GitHub
git push --set-upstream origin backport/backport-14274-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
This was referenced Jun 13, 2024
3 tasks
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
…pensearch-project#14037)" (opensearch-project#14274) This reverts commit afeddc2. Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…pensearch-project#14037)" (opensearch-project#14274) This reverts commit afeddc2. Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…14037)"
This reverts commit afeddc2.
Issue : #14270
Description
The PR introduced flaky test #14270
Related Issues
Resolves #14270
Check List
Functionality includes testing.API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.