Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add checks to skip remote uploads after shard is closed #13998

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

shourya035
Copy link
Member

@shourya035 shourya035 commented Jun 5, 2024

Description

Adding checks in RemoteStoreRefreshListener to return false for shouldSync if the underlying indexShard instance has transitioned to a CLOSED state. This would prevent the shouldRetry method to schedule refresh retries even after the IndexShard instance and it's corresponding Remote directories are closed.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

#13996

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
@shourya035 shourya035 changed the title Adding checks to skip remote refresh retry after shard is closed [Remote Store] Adding checks to skip remote refresh retry after shard is closed Jun 5, 2024
@shourya035 shourya035 changed the title [Remote Store] Adding checks to skip remote refresh retry after shard is closed [Remote Store] Adding checks to skip remote uploads retry after shard is closed Jun 5, 2024
@shourya035 shourya035 self-assigned this Jun 5, 2024
@shourya035 shourya035 marked this pull request as ready for review June 5, 2024 12:38
Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 6358f71: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 5, 2024

❌ Gradle check result for 6358f71: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 6, 2024

✅ Gradle check result for 6358f71: SUCCESS

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
@shourya035 shourya035 added the backport 2.x Backport to 2.x branch label Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for ebdc32c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for bf2e0e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@shourya035
Copy link
Member Author

❌ Gradle check result for bf2e0e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

org.opensearch.indices.IndicesRequestCacheIT.testDeleteAndCreateSameIndexShardOnSameNode

#13600

org.opensearch.indices.IndicesRequestCacheIT.testStaleKeysCleanupWithMultipleIndices {p0={"search.concurrent_segment_search.enabled":"false"}}

#13437

Copy link
Contributor

github-actions bot commented Jun 6, 2024

❌ Gradle check result for bf2e0e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Jun 6, 2024

✅ Gradle check result for bf2e0e9: SUCCESS

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.58%. Comparing base (b15cb0c) to head (bf2e0e9).
Report is 353 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13998      +/-   ##
============================================
+ Coverage     71.42%   71.58%   +0.16%     
- Complexity    59978    61316    +1338     
============================================
  Files          4985     5065      +80     
  Lines        282275   288201    +5926     
  Branches      40946    41741     +795     
============================================
+ Hits         201603   206309    +4706     
- Misses        63999    64852     +853     
- Partials      16673    17040     +367     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit b01b6e8 into opensearch-project:main Jun 6, 2024
30 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 6, 2024
#13998)

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
(cherry picked from commit b01b6e8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Jun 6, 2024
#13998) (#14035)

(cherry picked from commit b01b6e8)

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
opensearch-project#13998)

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
opensearch-project#13998) (opensearch-project#14035)

(cherry picked from commit b01b6e8)

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
opensearch-project#13998)

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants