Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of RemoteWritableEntity for objects to uploaded to remote store #13834

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

soosinha
Copy link
Member

@soosinha soosinha commented May 27, 2024

Description

This change implements the interface created in the PR #13785. The implementation is done for the objects which need to be uploaded to remote store.

Related Issues

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 6842837: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for ee52329: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the PR needs to be refreshed based on the #13785

@soosinha soosinha force-pushed the rs-impl branch 3 times, most recently from 034395a to 8a8622c Compare June 6, 2024 09:18
@soosinha soosinha changed the title Implementation of RemoteObject for objects to uploaded to remote store Implementation of RemoteWritableEntity for objects to uploaded to remote store Jun 6, 2024
@soosinha soosinha marked this pull request as ready for review June 6, 2024 09:18
Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Copy link
Contributor

github-actions bot commented Jun 8, 2024

✅ Gradle check result for a2aafaa: SUCCESS

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.73%. Comparing base (b15cb0c) to head (a2aafaa).
Report is 371 commits behind head on main.

Files Patch % Lines
...ay/remote/model/RemoteClusterMetadataManifest.java 75.60% 6 Missing and 4 partials ⚠️
...rch/gateway/remote/model/RemoteCustomMetadata.java 96.42% 1 Missing ⚠️
...rch/gateway/remote/model/RemoteGlobalMetadata.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13834      +/-   ##
============================================
+ Coverage     71.42%   71.73%   +0.31%     
- Complexity    59978    61692    +1714     
============================================
  Files          4985     5089     +104     
  Lines        282275   289404    +7129     
  Branches      40946    41858     +912     
============================================
+ Hits         201603   207603    +6000     
- Misses        63999    64661     +662     
- Partials      16673    17140     +467     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 49282c1 into opensearch-project:main Jun 8, 2024
30 checks passed
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Jun 8, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13834-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49282c111c593bb2b1ee76b50102c06fa1f2c627
# Push it to GitHub
git push --set-upstream origin backport/backport-13834-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13834-to-2.x.

soosinha added a commit to soosinha/OpenSearch that referenced this pull request Jun 8, 2024
…ote store (opensearch-project#13834)

* Implementation of RemoteWritableEntity for objects to uploaded to remote store

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
soosinha added a commit to soosinha/OpenSearch that referenced this pull request Jun 8, 2024
…ote store (opensearch-project#13834)

* Implementation of RemoteWritableEntity for objects to uploaded to remote store

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
soosinha added a commit to soosinha/OpenSearch that referenced this pull request Jun 9, 2024
…ote store (opensearch-project#13834)

* Implementation of RemoteWritableEntity for objects to uploaded to remote store

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
soosinha added a commit to soosinha/OpenSearch that referenced this pull request Jun 9, 2024
…ote store (opensearch-project#13834)

* Implementation of RemoteWritableEntity for objects to uploaded to remote store

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
shwetathareja pushed a commit that referenced this pull request Jun 10, 2024
…ote store (#13834) (#14098)

* Implementation of RemoteWritableEntity for objects to uploaded to remote store

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
…ote store (opensearch-project#13834)

* Implementation of RemoteWritableEntity for objects to uploaded to remote store

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…ote store (opensearch-project#13834) (opensearch-project#14098)

* Implementation of RemoteWritableEntity for objects to uploaded to remote store

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…ote store (opensearch-project#13834)

* Implementation of RemoteWritableEntity for objects to uploaded to remote store

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed skip-changelog v2.15.0 Issues and PRs related to version 2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants