Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Allow clearing remote_store.compatibility_mode setting #13761

Conversation

BhumikaSaini-Amazon
Copy link
Contributor

@BhumikaSaini-Amazon BhumikaSaini-Amazon commented May 21, 2024

Description

Backport f8baa4a from #13646.

Manual backport for #13657

Related Issues

Resolves #13634

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working good first issue Good for newcomers low hanging fruit Storage Issues and PRs relating to data and metadata storage Storage:Remote v2.15.0 Issues and PRs related to version 2.15.0 labels May 21, 2024
@BhumikaSaini-Amazon BhumikaSaini-Amazon changed the base branch from backport/backport-13646-to-2.x to 2.x May 21, 2024 04:42
@BhumikaSaini-Amazon BhumikaSaini-Amazon self-assigned this May 21, 2024
@BhumikaSaini-Amazon BhumikaSaini-Amazon marked this pull request as ready for review May 21, 2024 04:48
Copy link
Contributor

❌ Gradle check result for 06dc6c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 06dc6c5: SUCCESS

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.39%. Comparing base (0dd892c) to head (06dc6c5).
Report is 261 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13761      +/-   ##
============================================
+ Coverage     71.28%   71.39%   +0.11%     
- Complexity    60145    61371    +1226     
============================================
  Files          4957     5036      +79     
  Lines        282799   288201    +5402     
  Branches      41409    42110     +701     
============================================
+ Hits         201591   205764    +4173     
- Misses        64189    65100     +911     
- Partials      17019    17337     +318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers low hanging fruit Storage:Remote Storage Issues and PRs relating to data and metadata storage v2.15.0 Issues and PRs related to version 2.15.0
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants