Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repository-azure] plugin should use Azure Storage SDK v12 for Java #1302

Merged
merged 1 commit into from
Oct 18, 2021
Merged

[repository-azure] plugin should use Azure Storage SDK v12 for Java #1302

merged 1 commit into from
Oct 18, 2021

Conversation

reta
Copy link
Collaborator

@reta reta commented Sep 27, 2021

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Unfortunately, the repository-azure uses Legacy Storage SDK v8 for Java [1] which is not supported and not maintained anymore [2], [3]. The PR updates Azure Repository plugin to use latest Azure Storage SDK v12 for Java [4].

Although v8 and v12 APIs are completely different, it is possible to mimic the existing behaviour so the plugin users should not see the difference (notably, LocationMode and OperationContext, which are gone).

Right now only Netty client is being supported (the Azure Storage SDK v12 also supports OkHttp).

Issues Resolved

Closes #1225

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[1] https://github.com/Azure/azure-storage-java
[2] https://github.com/Azure/azure-storage-java/blob/master/V12%20Upgrade%20Story.md
[3] https://azure.microsoft.com/en-us/blog/previewing-azure-sdks-following-new-azure-sdk-api-standards/
[4] https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/storage

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 06504d73caed2de2aafa2cb210b8fb58c89aff71

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 06504d73caed2de2aafa2cb210b8fb58c89aff71

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 06504d73caed2de2aafa2cb210b8fb58c89aff71

@reta reta mentioned this pull request Sep 29, 2021
Closed
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@reta reta force-pushed the issue-1225.netty branch from 06504d7 to 4c2c951 Compare October 6, 2021 21:21
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 4c2c951b862748ccb164eb4a73b5a76831dca6ab

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 4c2c951b862748ccb164eb4a73b5a76831dca6ab

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 4c2c951b862748ccb164eb4a73b5a76831dca6ab

@reta
[repository-azure] plugin should use Azure Storage SDK v12 for Java
4c53cdd 
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta force-pushed the issue-1225.netty branch from 4c2c951 to 4c53cdd Compare October 15, 2021 19:41
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 4c53cdd

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 4c53cdd

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 4c53cdd

@reta reta marked this pull request as ready for review October 18, 2021 13:49
@reta
Copy link
Collaborator Author

reta commented Oct 18, 2021

@nknize @dblock @tlfeng would really appreciate if you find time to review, seems like all outstanding issues were sorted out, thank you!

@dblock
Copy link
Member

dblock commented Oct 18, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 4c53cdd
Log 718

Reports 718

@dblock dblock merged commit 9612fe8 into opensearch-project:main Oct 18, 2021
@dblock dblock added the pending backport Identifies an issue or PR that still needs to be backported label Oct 18, 2021
@dblock
Copy link
Member

dblock commented Oct 18, 2021

Backport to 1.x?

@reta
Copy link
Collaborator Author

reta commented Oct 18, 2021

Backport to 1.x?

Yes, will do, thanks a lot! I think the build will fail, the c7f5c90 went in with updated netty deps (SHAs have changed), I will sent a fix asap.

@reta reta mentioned this pull request Oct 19, 2021
Merged
5 tasks
@dblock
Copy link
Member

dblock commented Oct 19, 2021

Did this cause #1381 (comment)?

@reta
Copy link
Collaborator Author

reta commented Oct 19, 2021

Did this cause #1381 (comment)?

@dblock Yes, the `Execution failed for task ':plugins:repository-azure:thirdPartyAudit' but should be fixed by #1384

reta added a commit to reta/OpenSearch that referenced this pull request Oct 21, 2021
@reta
[repository-azure] plugin should use Azure Storage SDK v12 for Java (o…
a308cd3 
…pensearch-project#1302)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta mentioned this pull request Oct 21, 2021
Merged
5 tasks
dblock pushed a commit that referenced this pull request Oct 21, 2021
@reta
[repository-azure] plugin should use Azure Storage SDK v12 for Java (#…
c70a72c 
…1302) (#1409)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@dblock dblock removed the pending backport Identifies an issue or PR that still needs to be backported label Dec 6, 2021
@dblock dblock mentioned this pull request Apr 14, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugins: [repository-azure] plugin should use Azure Storage SDK v12 for Java
3 participants
@reta @opensearch-ci-bot @dblock