Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Accurate query-level resource usages instrumentation on Cluster Manager #12473

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Feb 27, 2024

Accurate instrumentation: correlate queries and tasks results on cluster manager node. More specifically, this PR:

  • Move the top N queries processing logic from each coordinator node to cluster manager node only
  • Cluster manager node is now responsible for fetching query level information and task level resource usage information from each data node, and correlated them to calculate accurate query-level top n resource usage information
  • Altered the Top N queries API to propergate _insights/top_queries api to cluser manager node only.

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 416d41e

Incompatible components

Skipped components

Compatible components

Copy link
Contributor

❌ Gradle check result for 416d41e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Mar 28, 2024
@kotwanikunal
Copy link
Member

Closing this PR - it has been in a draft state since a while.
@ansjcy Please reopen if you are still working on it.

@ansjcy ansjcy changed the title Accurate query-level resource usages instrumentation on Cluster Manager [POC] Accurate query-level resource usages instrumentation on Cluster Manager Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalled Issues that have stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants