Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow security manager in IntelliJ unit tests #12330

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Allow security manager in IntelliJ unit tests #12330

merged 1 commit into from
Feb 15, 2024

Conversation

andrross
Copy link
Member

If you configure IntelliJ to use JDK 21 then all unit tests will fail to run in the IDE when attempting to set the security manager in the test bootstrap code. This change configures all tests to include the required VM argument to enable the security manager.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross
Allow security manager in IntelliJ unit tests
931981c 
If you configure IntelliJ to use JDK 21 then all unit tests will fail to
run in the IDE when attempting to set the security manager in the test
bootstrap code. This change configures all tests to include the required
VM argument to enable the security manager.

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 931981c

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

kkmr
kkmr approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@kkmr kkmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have run into this often enough :-)

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 931981c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb0b4b0) 71.46% compared to head (931981c) 71.37%.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12330      +/-   ##
============================================
- Coverage     71.46%   71.37%   -0.10%     
+ Complexity    59831    59756      -75     
============================================
  Files          4959     4959              
  Lines        281129   281129              
  Branches      40857    40857              
============================================
- Hits         200917   200655     -262     
- Misses        63509    63747     +238     
- Partials      16703    16727      +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit f73c82a into opensearch-project:main Feb 15, 2024
106 of 107 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Feb 15, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 15, 2024
@github-actions
Allow security manager in IntelliJ unit tests (#12330)
870f574 
If you configure IntelliJ to use JDK 21 then all unit tests will fail to
run in the IDE when attempting to set the security manager in the test
bootstrap code. This change configures all tests to include the required
VM argument to enable the security manager.

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit f73c82a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 15, 2024
Merged
@andrross andrross deleted the idea-jdk-21 branch February 15, 2024 16:27
kotwanikunal pushed a commit that referenced this pull request Feb 15, 2024
@opensearch-trigger-bot @github-actions
Allow security manager in IntelliJ unit tests (#12330) (#12335)
ae7cb0c 
If you configure IntelliJ to use JDK 21 then all unit tests will fail to
run in the IDE when attempting to set the security manager in the test
bootstrap code. This change configures all tests to include the required
VM argument to enable the security manager.


(cherry picked from commit f73c82a)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
@andrross
Allow security manager in IntelliJ unit tests (opensearch-project#12330)
7c83b51 
If you configure IntelliJ to use JDK 21 then all unit tests will fail to
run in the IDE when attempting to set the security manager in the test
bootstrap code. This change configures all tests to include the required
VM argument to enable the security manager.

Signed-off-by: Andrew Ross <andrross@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@andrross @rayshrey
Allow security manager in IntelliJ unit tests (opensearch-project#12330)
cc3ba76 
If you configure IntelliJ to use JDK 21 then all unit tests will fail to
run in the IDE when attempting to set the security manager in the test
bootstrap code. This change configures all tests to include the required
VM argument to enable the security manager.

Signed-off-by: Andrew Ross <andrross@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@andrross @shiv0408
Allow security manager in IntelliJ unit tests (opensearch-project#12330)
cf2c9ec 
If you configure IntelliJ to use JDK 21 then all unit tests will fail to
run in the IDE when attempting to set the security manager in the test
bootstrap code. This change configures all tests to include the required
VM argument to enable the security manager.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
bowenlan-amzn pushed a commit to bowenlan-amzn/OpenSearch that referenced this pull request May 24, 2024
@andrross @bowenlan-amzn
Allow security manager in IntelliJ unit tests (opensearch-project#12330)
258db1f 
If you configure IntelliJ to use JDK 21 then all unit tests will fail to
run in the IDE when attempting to set the security manager in the test
bootstrap code. This change configures all tests to include the required
VM argument to enable the security manager.

Signed-off-by: Andrew Ross <andrross@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@mch2 mch2 mch2 approved these changes

@kkmr kkmr kkmr approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrross @reta @mch2 @kkmr