Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Top N Queries by latency implementation #12202

Closed
wants to merge 1 commit into from
Closed

[Backport 2.x] Top N Queries by latency implementation #12202

wants to merge 1 commit into from
+1,705 −6

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 554cbf7 from #11904.

@github-actions
Top N Queries by latency implementation (#11904)
0249f87 
* Top N Queries by latency implementation
* Increase JavaDoc coverage and update PR based comments
* Refactor record and service to make them generic
* refactor service for improving multithreading efficiency
* rebase from master to pick up query insights plugin changes

---------

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 554cbf7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ansjcy ansjcy added the v2.12.0 Issues and PRs related to version 2.12.0 label Feb 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Compatibility status:

Checks if related components are compatible with change 0249f87

Incompatible components

Skipped components

Compatible components

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

❌ Gradle check result for 0249f87: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40ad938) 71.11% compared to head (bf83859) 71.04%.
Report is 3 commits behind head on 2.x.

❗ Current head bf83859 differs from pull request most recent head 0249f87. Consider uploading reports for the commit 0249f87 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #12202      +/-   ##
============================================
- Coverage     71.11%   71.04%   -0.08%     
+ Complexity    59663    59637      -26     
============================================
  Files          4922     4922              
  Lines        281137   281137              
  Branches      41177    41177              
============================================
- Hits         199941   199725     -216     
- Misses        64235    64512     +277     
+ Partials      16961    16900      -61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansjcy
Copy link
Member

ansjcy commented Feb 6, 2024

Closing this one. Resolved the compilation error in this manual backport PR: #12203

@ansjcy ansjcy closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
Test roadmap format
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ansjcy