Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Query insights plugin implementation (#11903) #12199

Merged

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Feb 6, 2024

Backporting #11903 to 2.x


Signed-off-by: Chenyang Ji cyji@amazon.com
(cherry picked from commit 3cbf54e)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Query insights plugin implementation

Signed-off-by: Chenyang Ji <cyji@amazon.com>

* Increase JavaDoc coverage and update PR based comments

Signed-off-by: Chenyang Ji <cyji@amazon.com>

* Refactor record and service to make them generic

Signed-off-by: Chenyang Ji <cyji@amazon.com>

* refactor service for improving multithreading efficiency

Signed-off-by: Chenyang Ji <cyji@amazon.com>

---------

Signed-off-by: Chenyang Ji <cyji@amazon.com>
(cherry picked from commit 3cbf54e)
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Compatibility status:

Checks if related components are compatible with change 615dd22

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git]

@ansjcy ansjcy added the v2.12.0 Issues and PRs related to version 2.12.0 label Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

❕ Gradle check result for 615dd22: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testIndexReopenClose

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (40ad938) 71.11% compared to head (615dd22) 71.14%.
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...in/insights/core/service/QueryInsightsService.java 54.16% 17 Missing and 5 partials ⚠️
...plugin/insights/rules/model/SearchQueryRecord.java 51.16% 15 Missing and 6 partials ⚠️
...lugin/insights/core/service/TopQueriesService.java 87.67% 4 Missing and 5 partials ⚠️
...search/plugin/insights/rules/model/MetricType.java 77.77% 2 Missing and 2 partials ⚠️
...opensearch/action/search/SearchRequestSlowLog.java 0.00% 4 Missing ⚠️
...pensearch/plugin/insights/QueryInsightsPlugin.java 66.66% 3 Missing ⚠️
...action/search/SearchRequestOperationsListener.java 0.00% 2 Missing ⚠️
...lugin/insights/settings/QueryInsightsSettings.java 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12199      +/-   ##
============================================
+ Coverage     71.11%   71.14%   +0.02%     
- Complexity    59663    59750      +87     
============================================
  Files          4922     4929       +7     
  Lines        281137   281349     +212     
  Branches      41177    41202      +25     
============================================
+ Hits         199941   200168     +227     
+ Misses        64235    64193      -42     
- Partials      16961    16988      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit 9f1f724 into opensearch-project:2.x Feb 6, 2024
81 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants