Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty translog for ITs testing no ingestion post refresh/commit #11946

Conversation

linuxpi
Copy link
Collaborator

@linuxpi linuxpi commented Jan 19, 2024

Description

  • RemoteStoreRestoreIT has bunch of tests which require empty translog during restore, ie no data is ingested after last refresh/commit.
  • Currently our tests were ingesting data even after last refresh/commit even though tests did not want that.
  • This PR allows last iteration of data ingestion method to skip ingestion after last refresh/commit

Related Issues

NA

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: bansvaru <bansvaru@amazon.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 1466b82

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git]

Copy link
Contributor

✅ Gradle check result for 1466b82: SUCCESS

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c132db9) 71.33% compared to head (1466b82) 71.35%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11946      +/-   ##
============================================
+ Coverage     71.33%   71.35%   +0.01%     
- Complexity    59300    59321      +21     
============================================
  Files          4921     4921              
  Lines        278989   278989              
  Branches      40543    40543              
============================================
+ Hits         199014   199061      +47     
+ Misses        63444    63338     -106     
- Partials      16531    16590      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linuxpi linuxpi self-assigned this Jan 19, 2024
@sachinpkale sachinpkale merged commit e265355 into opensearch-project:main Jan 19, 2024
91 of 130 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Jan 19, 2024
@linuxpi linuxpi deleted the fix-remote-restore-it-empty-translog branch January 19, 2024 11:27
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 19, 2024
…#11946)

Signed-off-by: bansvaru <bansvaru@amazon.com>
(cherry picked from commit e265355)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VachaShah pushed a commit that referenced this pull request Jan 22, 2024
…#11946) (#11949)

(cherry picked from commit e265355)

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…opensearch-project#11946)

Signed-off-by: bansvaru <bansvaru@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants