Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check LongVector.SPECIES_PREFERRED when jdk.incubator.vector is enabled #11939

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Only check LongVector.SPECIES_PREFERRED when jdk.incubator.vector is enabled #11939

merged 1 commit into from
Jan 18, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 18, 2024 •
edited
Loading

Description

Since non-core plugins run integration tests using JDK-21, the jdk.incubator.vector is not enabled by default, causing:

Caused by:                                                                                                                                                   
java.lang.NoClassDefFoundError: jdk/incubator/vector/LongVector                                                                                              
    at __randomizedtesting.SeedInfo.seed([D65A64F81C71BE2B]:0)                                                                                               
    at org.opensearch.common.round.RoundableFactory.<clinit>(RoundableFactory.java:39)                                                                       
    at org.opensearch.common.Rounding$PreparedRounding.maybeUseArray(Rounding.java:454)                                        
    at org.opensearch.common.Rounding$TimeUnitRounding.prepare(Rounding.java:569)                                             
    at org.opensearch.search.aggregations.support.CoreValuesSourceType$7$1.lambda$roundingPreparer$0(CoreValuesSourceType.java:401)                          
    at org.opensearch.search.aggregations.bucket.histogram.DateHistogramAggregatorFactory.doCreateInternal(DateHistogramAggregatorFactory.java:113)       
    at org.opensearch.search.aggregations.support.ValuesSourceAggregatorFactory.createInternal(ValuesSourceAggregatorFactory.java:76)
    at org.opensearch.search.aggregations.AggregatorFactory.create(AggregatorFactory.java:103)                                                               
    at org.opensearch.search.aggregations.AggregatorFactories.createTopLevelAggregators(AggregatorFactories.java:315)                                        
    at org.opensearch.search.aggregations.AggregatorFactories.createTopLevelNonGlobalAggregators(AggregatorFactories.java:301)                               
    at org.opensearch.search.aggregations.AggregationCollectorManager.newCollector(AggregationCollectorManager.java:45)                                      
    at org.opensearch.search.aggregations.NonGlobalAggCollectorManagerWithSingleCollector.<init>(NonGlobalAggCollectorManagerWithSingleCollector.java:33)    
    at org.opensearch.search.aggregations.DefaultAggregationProcessor.preProcess(DefaultAggregationProcessor.java:37)                                        
    at org.opensearch.search.query.QueryPhase.execute(QueryPhase.java:154)                                                                                   
    at org.opensearch.search.SearchService.loadOrExecuteQueryPhase(SearchService.java:546)                                                                   
    at org.opensearch.search.SearchService.executeQueryPhase(SearchService.java:610)                                                                         
    at org.opensearch.search.SearchService$2.lambda$onResponse$0(SearchService.java:579)                                                                     
    at org.opensearch.action.ActionRunnable.lambda$supply$0(ActionRunnable.java:74)                                                                          
    at org.opensearch.action.ActionRunnable$2.doRun(ActionRunnable.java:89)                                                                                  
    at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:52)                                                                  
    at org.opensearch.threadpool.TaskAwareRunnable.doRun(TaskAwareRunnable.java:78)                                                                       
    at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:52)                                                                  
    at org.opensearch.common.util.concurrent.TimedRunnable.doRun(TimedRunnable.java:59)                                                                      
    at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:913)                                   
    at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:52)                                                                  
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)                                                             
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)                                                             
    at java.base/java.lang.Thread.run(Thread.java:1583)                                                                                                      
                                                                                                                                                             
    Caused by:                                                                                                                                               
    java.lang.ClassNotFoundException: jdk.incubator.vector.LongVector                                                                                        
        at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)                                                           
        at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)                                                        
        at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)                                                                                   
        ... 27 more

Related Issues

Closes #11937

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Plugins labels Jan 18, 2024
@reta
Copy link
Collaborator Author

reta commented Jan 18, 2024

@ketanv3 fyi, @andrross could you please approve?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 0f7d1ab: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Only check LongVector.SPECIES_PREFERRED when jdk.incubator.vector is …
5d52aea 
…enabled

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 18, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 5d52aea

Incompatible components

Incompatible components: [https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git]

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 5d52aea: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f81c57) 71.33% compared to head (5d52aea) 71.40%.
Report is 4 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11939      +/-   ##
============================================
+ Coverage     71.33%   71.40%   +0.06%     
- Complexity    59362    59432      +70     
============================================
  Files          4923     4923              
  Lines        279189   279189              
  Branches      40591    40591              
============================================
+ Hits         199169   199360     +191     
+ Misses        63449    63227     -222     
- Partials      16571    16602      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 774e7d4 into opensearch-project:main Jan 18, 2024
30 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Jan 18, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 18, 2024
@github-actions
Only check LongVector.SPECIES_PREFERRED when jdk.incubator.vector is …
66007fb 
…enabled (#11939)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 774e7d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 18, 2024
Merged
reta pushed a commit that referenced this pull request Jan 19, 2024
@opensearch-trigger-bot @github-actions
Only check LongVector.SPECIES_PREFERRED when jdk.incubator.vector is …
f54ae8b 
…enabled (#11939) (#11943)

(cherry picked from commit 774e7d4)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
@reta
Only check LongVector.SPECIES_PREFERRED when jdk.incubator.vector is …
4685e22 
…enabled (opensearch-project#11939)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@reta @rayshrey
Only check LongVector.SPECIES_PREFERRED when jdk.incubator.vector is …
8677cab 
…enabled (opensearch-project#11939)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@reta @shiv0408
Only check LongVector.SPECIES_PREFERRED when jdk.incubator.vector is …
641dd44 
…enabled (opensearch-project#11939)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrross andrross andrross approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Plugins skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] The non-core plugin test cases fail due to the use of JDK incubator features
2 participants
@reta @andrross