Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid BulkRequest construction for indexRandom() #11516

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Dec 7, 2023

Description

Fix invalid BulkRequest construction for indexRandom():

org.opensearch.action.ActionRequestValidationException: Validation Failed: 1: RefreshPolicy is not supported on an item request. Set it on the BulkRequest instead.;2: RefreshPolicy is not supported on an item request. Set it on the BulkRequest instead.;3: RefreshPolicy is not supported on an item request. Set it on the BulkRequest instead.;4: RefreshPolicy is not supported on an item request. Set it on the BulkRequest instead.;
	at __randomizedtesting.SeedInfo.seed([19EE5058CA5DFA10:CEAC4ADCAF30EA37]:0)
	at app//org.opensearch.action.ValidateActions.addValidationError(ValidateActions.java:44)
	at app//org.opensearch.action.bulk.BulkRequest.validate(BulkRequest.java:432)
	at app//org.opensearch.action.support.TransportAction.execute(TransportAction.java:177)
	at app//org.opensearch.action.support.TransportAction.execute(TransportAction.java:107)
	at app//org.opensearch.client.node.NodeClient.executeLocally(NodeClient.java:110)
	at app//org.opensearch.client.node.NodeClient.doExecute(NodeClient.java:97)
	at app//org.opensearch.client.support.AbstractClient.execute(AbstractClient.java:476)
	at app//org.opensearch.client.FilterClient.doExecute(FilterClient.java:83)
	at app//org.opensearch.client.support.AbstractClient.execute(AbstractClient.java:476)
	at app//org.opensearch.client.support.AbstractClient.execute(AbstractClient.java:463)
	at app//org.opensearch.action.ActionRequestBuilder.execute(ActionRequestBuilder.java:66)
	at app//org.opensearch.test.OpenSearchIntegTestCase.indexRandom(OpenSearchIntegTestCase.java:1651)
	at app//org.opensearch.test.OpenSearchIntegTestCase.indexRandom(OpenSearchIntegTestCase.java:1582)
	at app//org.opensearch.test.OpenSearchIntegTestCase.indexRandom(OpenSearchIntegTestCase.java:1566)
	at app//org.opensearch.search.suggest.CompletionSuggestSearchIT.testSkipDuplicates(CompletionSuggestSearchIT.java:1199)

Related Issues

See please:

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Compatibility status:

Checks if related components are compatible with change 270a329

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Dec 7, 2023

✅ Gradle check result for 270a329: SUCCESS

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ad2d4c) 71.40% compared to head (270a329) 71.29%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11516      +/-   ##
============================================
- Coverage     71.40%   71.29%   -0.11%     
- Complexity    59146    59151       +5     
============================================
  Files          4904     4904              
  Lines        278149   278149              
  Branches      40419    40419              
============================================
- Hits         198599   198320     -279     
- Misses        63020    63346     +326     
+ Partials      16530    16483      -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied peternied merged commit 215fb22 into opensearch-project:main Dec 7, 2023
101 of 135 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Dec 7, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 7, 2023
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 215fb22)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Dec 7, 2023
(cherry picked from commit 215fb22)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Dec 11, 2023
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…oject#11516)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants