-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix explanation message for TargetPoolAllocationDecider #11449
Fix explanation message for TargetPoolAllocationDecider #11449
Conversation
Signed-off-by: panguixin <panguixin@bytedance.com>
Compatibility status:Checks if related components are compatible with change dc6b61e Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git] |
❕ Gradle check result for dc6b61e: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11449 +/- ##
============================================
+ Coverage 71.28% 71.37% +0.09%
- Complexity 59033 59095 +62
============================================
Files 4893 4893
Lines 277753 277834 +81
Branches 40357 40367 +10
============================================
+ Hits 197989 198316 +327
+ Misses 63288 63025 -263
- Partials 16476 16493 +17 ☔ View full report in Codecov by Sentry. |
Signed-off-by: panguixin <panguixin@bytedance.com> (cherry picked from commit effc9bc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) (cherry picked from commit effc9bc) Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…roject#11449) Signed-off-by: panguixin <panguixin@bytedance.com>
…roject#11449) Signed-off-by: panguixin <panguixin@bytedance.com>
…roject#11449) Signed-off-by: panguixin <panguixin@bytedance.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
[Describe what this change achieves]
TargetPoolAllocationDecider doesn't use correct format when return
Decision
, resulting in an explanation message that reads something likeRouting pools are incompatible. Shard pool: [{}], Node Pool: [{}] without [{}] role
.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.