-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment Replication] Handle exceptions on local file read during replication #10933
[Segment Replication] Handle exceptions on local file read during replication #10933
Conversation
server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTarget.java
Outdated
Show resolved
Hide resolved
Compatibility status:Checks if related components are compatible with change cc0e090 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10933 +/- ##
============================================
+ Coverage 71.18% 71.29% +0.11%
- Complexity 58758 58771 +13
============================================
Files 4872 4872
Lines 276682 276687 +5
Branches 40219 40219
============================================
+ Hits 196963 197277 +314
+ Misses 63366 62986 -380
- Partials 16353 16424 +71
|
Signed-off-by: Suraj Singh <surajrider@gmail.com>
aa0b433
to
cc0e090
Compare
I striked out the CheckList items which are not applicable but I am still seeing |
Gradle Check (Jenkins) Run Completed with:
|
…lication (#10933) * Handle exceptions on file read Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> (cherry picked from commit 003b2cf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…lication (#10933) (#10936) * Handle exceptions on file read * Address review comments --------- (cherry picked from commit 003b2cf) Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…lication (opensearch-project#10933) * Handle exceptions on file read Signed-off-by: Suraj Singh <surajrider@gmail.com> * Address review comments Signed-off-by: Suraj Singh <surajrider@gmail.com> --------- Signed-off-by: Suraj Singh <surajrider@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This change avoid replication failures in event of exception when reading the local file not currently referenced by reader. This is useful and cover scenarios where reading the on-disk results in IOException due to file corruption or partial writes.
Without change, the added unit test depicts replication event failure.
Related Issues
Resolves None
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.