Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Unmute Test SegmentReplicationTargetServiceTests.testShardAlreadyReplicating #10660

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

Rishikesh1159
Copy link
Member

Description

This PR unmutes Test SegmentReplicationTargetServiceTests.testShardAlreadyReplicating

Related Issues

Resolves #8928

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@github-actions github-actions bot added >test-failure Test failure from CI, local build, etc. bug Something isn't working flaky-test Random test failure that succeeds on second run labels Oct 17, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Compatibility status:

Checks if related components are compatible with change c7aa4f6

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #10660 (c7aa4f6) into main (8bc6791) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main   #10660   +/-   ##
=========================================
  Coverage     71.15%   71.16%           
+ Complexity    58497    58472   -25     
=========================================
  Files          4853     4853           
  Lines        275758   275758           
  Branches      40134    40134           
=========================================
+ Hits         196215   196240   +25     
+ Misses        63162    63111   -51     
- Partials      16381    16407   +26     

see 481 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please look at the flaky gradle checks in this PR and link the issues for those?

@dblock dblock added skip-changelog backport 2.x Backport to 2.x branch labels Oct 17, 2023
@dblock
Copy link
Member

dblock commented Oct 17, 2023

@Rishikesh1159 I can't tell from #8928 where this was fixed?

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
@Rishikesh1159
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

Failure reason: ':server:spotlessJavaCheck'

@Rishikesh1159
Copy link
Member Author

@Rishikesh1159 I can't tell from #8928 where this was fixed?

I am not able to reproduce the test failure. I tried running entire test suite class but still not able to reproduce. This flaky test might be fixed from some changes happened in last 2 months. I am adding trace logging with test, so next time if we see this test failing we can get more info from logs.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.ShardIndexingPressureIT.testShardIndexingPressureTrackingDuringBulkWrites

@Rishikesh1159
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.index.ShardIndexingPressureIT.testShardIndexingPressureTrackingDuringBulkWrites

known flaky test: #5176

@Rishikesh1159 Rishikesh1159 merged commit e942483 into opensearch-project:main Oct 18, 2023
16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 18, 2023
…s.testShardAlreadyReplicating (#10660)

* Remove Awaits fix.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* apply spotlesscheck.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* add test logging.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
(cherry picked from commit e942483)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 19, 2023
…s.testShardAlreadyReplicating (opensearch-project#10660)

* Remove Awaits fix.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* apply spotlesscheck.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* add test logging.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
…s.testShardAlreadyReplicating (opensearch-project#10660)

* Remove Awaits fix.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* apply spotlesscheck.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* add test logging.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…s.testShardAlreadyReplicating (opensearch-project#10660)

* Remove Awaits fix.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* apply spotlesscheck.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

* add test logging.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

---------

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working flaky-test Random test failure that succeeds on second run skip-changelog >test-failure Test failure from CI, local build, etc.
Projects
None yet
3 participants