Add assert for codec version

Signed-off-by: Sooraj Sinha <soosinha@amazon.com>
opensearch-project · Aug 28, 2024 · 6a05b5a · 6a05b5a
1 parent 358f492
commit 6a05b5a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/server/src/main/java/org/opensearch/cluster/coordination/Coordinator.java b/server/src/main/java/org/opensearch/cluster/coordination/Coordinator.java
@@ -1337,7 +1337,7 @@ assert getLocalNode().equals(clusterState.getNodes().get(getLocalNode().getId())
                     coordinationState.get().isRemotePublicationEnabled(),
                     persistedStateRegistry
                 );
-                logger.info("initialized publicationcontext using class: {}", publicationContext.getClass().toString());
+                logger.debug("initialized PublicationContext using class: {}", publicationContext.getClass().toString());
 
                 final PublishRequest publishRequest = coordinationState.get().handleClientValue(clusterState);
                 final CoordinatorPublication publication = new CoordinatorPublication(

diff --git a/server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java b/server/src/main/java/org/opensearch/cluster/coordination/PublicationTransportHandler.java
@@ -355,9 +355,7 @@ public PublicationContext newPublicationContext(
     }
 
     private boolean validateRemotePublicationOnAllNodes(DiscoveryNodes discoveryNodes) {
-        if (ClusterMetadataManifest.getCodecForVersion(discoveryNodes.getMinNodeVersion()) < ClusterMetadataManifest.CODEC_V0) {
-            return false;
-        }
+        assert ClusterMetadataManifest.getCodecForVersion(discoveryNodes.getMinNodeVersion()) >= ClusterMetadataManifest.CODEC_V0;
         for (DiscoveryNode node : discoveryNodes.getNodes().values()) {
             // if a node is non-remote then created local publication context
             if (node.isRemoteStatePublicationEnabled() == false) {