Skip to content

Commit

Permalink
Add comments explaining test incompatibilities
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Widdis <widdis@gmail.com>
  • Loading branch information
dbwiddis committed Jul 8, 2022
1 parent 04932ce commit 29ad2b5
Showing 1 changed file with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
import java.nio.file.InvalidPathException;
import java.nio.file.Path;

import com.carrotsearch.randomizedtesting.RandomizedTest;
import org.apache.tools.ant.taskdefs.condition.Os;
import org.opensearch.gradle.test.GradleUnitTestCase;
import org.gradle.api.Project;
import org.gradle.testfixtures.ProjectBuilder;
import org.opensearch.gradle.test.GradleUnitTestCase;

import com.carrotsearch.randomizedtesting.RandomizedTest;

public class EmptyDirTaskTests extends GradleUnitTestCase {

Expand All @@ -67,7 +67,10 @@ public void testCreateEmptyDir() throws Exception {
}

public void testCreateEmptyDirNoPermissions() throws Exception {
RandomizedTest.assumeFalse("Functionality is Unix specific", Os.isFamily(Os.FAMILY_WINDOWS));
// Test depends on Posix file permissions
RandomizedTest.assumeFalse("Functionality is Unix-like OS specific", Os.isFamily(Os.FAMILY_WINDOWS));
// Java's Files.setPosixFilePermissions is a NOOP inside a Docker container as
// files are created by default with UID and GID = 0 (root).
RandomizedTest.assumeFalse("Functionality doesn't work in Docker", isRunningInDocker());

Project project = ProjectBuilder.builder().build();
Expand Down

0 comments on commit 29ad2b5

Please sign in to comment.