Remove unnecessary assertBusy

Signed-off-by: Marc Handalian <handalm@amazon.com>
opensearch-project · Jul 14, 2023 · 0a539ac · 0a539ac
1 parent 9ab9fb5
commit 0a539ac
Showing 1 changed file with 12 additions and 15 deletions.
diff --git a/server/src/internalClusterTest/java/org/opensearch/action/search/TransportSearchIT.java b/server/src/internalClusterTest/java/org/opensearch/action/search/TransportSearchIT.java
@@ -371,7 +371,7 @@ public void testSearchIdle() throws Exception {
         });
     }
 
-    public void testSearchIdleWithSegmentReplication() throws Exception {
+    public void testSearchIdleWithSegmentReplication() {
         int numOfReplicas = 1;
         internalCluster().ensureAtLeastNumDataNodes(numOfReplicas + 1);
         final Settings.Builder settings = Settings.builder()
@@ -390,14 +390,12 @@ public void testSearchIdleWithSegmentReplication() throws Exception {
                 )
         );
 
-        assertBusy(() -> {
-            for (String node : internalCluster().nodesInclude("test")) {
-                final IndicesService indicesService = internalCluster().getInstance(IndicesService.class, node);
-                for (IndexShard indexShard : indicesService.indexServiceSafe(resolveIndex("test"))) {
-                    assertFalse(indexShard.isSearchIdleSupported());
-                }
+        for (String node : internalCluster().nodesInclude("test")) {
+            final IndicesService indicesService = internalCluster().getInstance(IndicesService.class, node);
+            for (IndexShard indexShard : indicesService.indexServiceSafe(resolveIndex("test"))) {
+                assertFalse(indexShard.isSearchIdleSupported());
             }
-        });
+        }
 
         assertAcked(
             client().admin()
@@ -406,14 +404,13 @@ public void testSearchIdleWithSegmentReplication() throws Exception {
                 .setSettings(Settings.builder().put(IndexMetadata.SETTING_NUMBER_OF_REPLICAS, 0))
         );
 
-        assertBusy(() -> {
-            for (String node : internalCluster().nodesInclude("test")) {
-                final IndicesService indicesService = internalCluster().getInstance(IndicesService.class, node);
-                for (IndexShard indexShard : indicesService.indexServiceSafe(resolveIndex("test"))) {
-                    assertTrue(indexShard.isSearchIdleSupported());
-                }
+        for (String node : internalCluster().nodesInclude("test")) {
+            final IndicesService indicesService = internalCluster().getInstance(IndicesService.class, node);
+            for (IndexShard indexShard : indicesService.indexServiceSafe(resolveIndex("test"))) {
+                assertTrue(indexShard.isSearchIdleSupported());
             }
-        });
+        }
+        ;
     }
 
     public void testCircuitBreakerReduceFail() throws Exception {