Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [navigation]Refactor: flatten left nav in Analytics(all) use case #8466

Merged
merged 1 commit into from
Oct 4, 2024

[navigation]Refactor: flatten left nav in Analytics(all) use case (#8…

c699a05
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.x] [navigation]Refactor: flatten left nav in Analytics(all) use case #8466

[navigation]Refactor: flatten left nav in Analytics(all) use case (#8…
c699a05
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 0s

61.02% (-0.02%) compared to 51344bf

View this Pull Request on Codecov

61.02% (-0.02%) compared to 51344bf

Details

Codecov Report

Attention: Patch coverage is 80.76923% with 15 lines in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (51344bf) to head (c699a05).

Files with missing lines Patch % Lines
.../core/public/chrome/nav_group/nav_group_service.ts 80.00% 1 Missing and 5 partials ⚠️
...public/chrome/ui/header/collapsible_nav_groups.tsx 55.55% 1 Missing and 3 partials ⚠️
...chrome/ui/header/collapsible_nav_group_enabled.tsx 60.00% 0 Missing and 2 partials ⚠️
.../chrome/ui/header/collapsible_nav_groups_label.tsx 86.66% 1 Missing and 1 partial ⚠️
.../public/components/feature_cards/feature_cards.tsx 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.x    #8466      +/-   ##
==========================================
- Coverage   61.04%   61.02%   -0.02%     
==========================================
  Files        3757     3758       +1     
  Lines       89299    89296       -3     
  Branches    13962    13958       -4     
==========================================
- Hits        54511    54492      -19     
- Misses      31403    31415      +12     
- Partials     3385     3389       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov