[Workspace] Refactor collaborators panel at workspace create #8382

Kapian1234 · 2024-09-30T04:58:21Z

Description

Refactor collaborators panel at workspace create

Issues Resolved

Screenshot

before

after

Testing the changes

Changelog

feat: Refactor collaborators panel at workspace create

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

codecov · 2024-09-30T05:22:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (a663a84) to head (dd34f7e).
Report is 150 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8382      +/-   ##
==========================================
- Coverage   60.92%   60.92%   -0.01%     
==========================================
  Files        3750     3750              
  Lines       89103    89104       +1     
  Branches    13925    13926       +1     
==========================================
- Hits        54285    54284       -1     
- Misses      31442    31443       +1     
- Partials     3376     3377       +1

Flag	Coverage Δ
Linux_1	`28.83% <100.00%> (+<0.01%)`	⬆️
Linux_2	`56.35% <ø> (ø)`
Linux_3	`37.72% <ø> (-0.01%)`	⬇️
Linux_4	`29.96% <ø> (ø)`
Windows_1	`28.84% <100.00%> (+<0.01%)`	⬆️
Windows_2	`56.30% <ø> (ø)`
Windows_3	`37.72% <ø> (ø)`
Windows_4	`29.96% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wanglam · 2024-09-30T06:02:09Z

src/plugins/workspace/public/components/workspace_creator/workspace_creator_form.tsx

-            </>
+            <EuiSplitPanel.Outer direction="column">
+              <EuiSplitPanel.Inner>
+                <EuiTitle


Can we use EuiTitle + h2 as panel title like this to align with the guidance.

wanglam · 2024-09-30T07:08:51Z

src/plugins/workspace/public/components/workspace_creator/workspace_creator_form.tsx

-                data-test-subj={`workspaceForm-permissionSettingPanel`}
-              />
-            </>
+            <EuiSplitPanel.Outer direction="column">


Any reason to use SplitPanel? Can we use EuiPanel instead?

No particular reason, I just happened to see that SplitPanel can achieve this effect. I'll change it to EuiPanel then.

It seems there will be a 32px gap between SplitPanel.Inner. Let use EuiPanel with EuiSpacer instead.

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

ruanyl · 2024-09-30T10:10:54Z

@Kapian1234 could you resolve the conflict please

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

ruanyl · 2024-09-30T12:04:27Z

@Kapian1234 Could you resolve the conflicts

…aborator_refactor Signed-off-by: Lin Wang <wonglam@amazon.com>

wanglam · 2024-10-01T04:17:19Z

@ruanyl The conflicts has been resolved, could you help me take a look?

SuZhou-Joe · 2024-10-01T05:16:06Z

src/plugins/workspace/public/components/workspace_form/workspace_permission_setting_panel.tsx

+            <EuiFlexItem grow={false}>
+              <EuiButtonIcon
+                color="text"
+                iconType="trash"
+                size="xs"
+                style={{ visibility: 'hidden' }}
+              />
+            </EuiFlexItem>


I am a little bit confused on this element, it contains a hidden element. Could you please elaborate more here?

I think this is a placeholder to align column label with inputs. I think we can change to fixed width div.

I c, thanks. A comment here would be preferred.

Sure. Will add some comments above.

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor collaborators panel Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR #8382 created/updated * update title style Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Modify panel and update title style Signed-off-by: Kapian1234 <wanjinch@amazon.com> * update placeholder Signed-off-by: Kapian1234 <wanjinch@amazon.com> * update placeholder Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Add comments for placeholder in permission setting panel Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 4b56be5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…8420) * refactor collaborators panel * Changeset file for PR #8382 created/updated * update title style * Modify panel and update title style * update placeholder * update placeholder * Add comments for placeholder in permission setting panel --------- (cherry picked from commit 4b56be5) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com>

…rch-project#8382) (opensearch-project#8420) * refactor collaborators panel * Changeset file for PR opensearch-project#8382 created/updated * update title style * Modify panel and update title style * update placeholder * update placeholder * Add comments for placeholder in permission setting panel --------- (cherry picked from commit 4b56be5) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com>

refactor collaborators panel

4b955cf

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

github-actions bot added the valued-contributor label Sep 30, 2024

Changeset file for PR opensearch-project#8382 created/updated

0b5a72f

Kapian1234 marked this pull request as ready for review September 30, 2024 05:00

wanglam reviewed Sep 30, 2024

View reviewed changes

ruanyl added the workspace label Sep 30, 2024

wanglam reviewed Sep 30, 2024

View reviewed changes

Kapian1234 added 3 commits September 30, 2024 16:08

Modify panel and update title style

6d4e50f

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

update placeholder

aa101d1

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

update placeholder

878fc1e

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

resolve conflicts and modify space

68e8ebe

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

ruanyl previously approved these changes Sep 30, 2024

View reviewed changes

Kapian1234 mentioned this pull request Sep 30, 2024

[Workspace] Refactor data source association panel #8383

Merged

7 tasks

Merge remote-tracking branch 'origin/main' into workspace_create_coll…

79ab040

…aborator_refactor Signed-off-by: Lin Wang <wonglam@amazon.com>

wanglam dismissed ruanyl’s stale review via 79ab040 October 1, 2024 02:49

SuZhou-Joe reviewed Oct 1, 2024

View reviewed changes

SuZhou-Joe previously approved these changes Oct 1, 2024

View reviewed changes

Add comments for placeholder in permission setting panel

dd34f7e

Signed-off-by: Lin Wang <wonglam@amazon.com>

wanglam dismissed SuZhou-Joe’s stale review via dd34f7e October 1, 2024 06:00

ruanyl approved these changes Oct 1, 2024

View reviewed changes

SuZhou-Joe approved these changes Oct 1, 2024

View reviewed changes

SuZhou-Joe merged commit 4b56be5 into opensearch-project:main Oct 1, 2024
67 checks passed

opensearch-trigger-bot bot added the failed backport label Oct 1, 2024

opensearch-project deleted a comment from opensearch-trigger-bot bot Oct 1, 2024

SuZhou-Joe added backport 2.x and removed backport 2.x failed backport labels Oct 1, 2024

opensearch-trigger-bot bot mentioned this pull request Oct 1, 2024

[Backport 2.x] [Workspace] Refactor collaborators panel at workspace create #8420

Merged

ananzh added the v2.18.0 label Oct 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] Refactor collaborators panel at workspace create #8382

[Workspace] Refactor collaborators panel at workspace create #8382

Kapian1234 commented Sep 30, 2024 •

edited

Loading

codecov bot commented Sep 30, 2024 •

edited

Loading

wanglam Sep 30, 2024

Kapian1234 Sep 30, 2024

wanglam Sep 30, 2024

Kapian1234 Sep 30, 2024

wanglam Sep 30, 2024

Kapian1234 Sep 30, 2024

ruanyl commented Sep 30, 2024

ruanyl commented Sep 30, 2024

wanglam commented Oct 1, 2024

SuZhou-Joe Oct 1, 2024

wanglam Oct 1, 2024

SuZhou-Joe Oct 1, 2024

wanglam Oct 1, 2024 •

edited

Loading

[Workspace] Refactor collaborators panel at workspace create #8382

[Workspace] Refactor collaborators panel at workspace create #8382

Conversation

Kapian1234 commented Sep 30, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

codecov bot commented Sep 30, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ruanyl commented Sep 30, 2024

ruanyl commented Sep 30, 2024

wanglam commented Oct 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wanglam Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

Kapian1234 commented Sep 30, 2024 •

edited

Loading

codecov bot commented Sep 30, 2024 •

edited

Loading

wanglam Oct 1, 2024 •

edited

Loading