Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] [Manual backport 2.x] [navigation] Add workspace icon to left nav / workspace picker menu / home page. (#7823) #8038

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 4c64d81 from #7995.

… home page. (#7823) (#7994) (#7995)

* feat: show workspace picker content in left nav

* fix: bootstrap error

* fix: unit test error

* feat: finish picker content

* feat: finish picker content

* feat: only register index patterns to settings and setup when workspace is disabled

* fix: unit test

* feat: put discover 2.0 behind discover

* feat: add coverage

* feat: improve test coverage

* feat: merge conflict

* feat: optimize code based on comment

* feat: optimize code based on comment

* feat: optimize filter code

* feat: update

* feat: add new icon to left navigation and workspace picker menu

* feat: change use case card in home

* feat: optimize alignment

* Changeset file for PR #7823 created/updated

* feat: alignment optimize

* feat: use new icons in workspace picker

* feat: optimize color

* fix: unit test error

* fix: unit test

* fix: unit test

* feat: increase test coverage

* feat: remove useless code

* Add workspace icon in workspace creator (#19)

* fix: fatal error when visibleUseCases is empty

---------

(cherry picked from commit 1974ca1)
(cherry picked from commit cbdb0fd)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lin Wang <wonglam@amazon.com>
(cherry picked from commit 4c64d81)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 60.55%. Comparing base (263cf25) to head (915275a).
Report is 4 commits behind head on 2.17.

Files with missing lines Patch % Lines
...me/ui/header/collapsible_nav_group_enabled_top.tsx 78.57% 0 Missing and 3 partials ⚠️
...nents/home_get_start_card/setup_get_start_card.tsx 0.00% 2 Missing ⚠️
...ic/components/use_case_overview/setup_overview.tsx 0.00% 2 Missing ⚠️
...ublic/components/workspace_menu/workspace_menu.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.17    #8038      +/-   ##
==========================================
- Coverage   60.56%   60.55%   -0.01%     
==========================================
  Files        3723     3723              
  Lines       88097    88108      +11     
  Branches    13614    13620       +6     
==========================================
+ Hits        53352    53356       +4     
- Misses      31510    31513       +3     
- Partials     3235     3239       +4     
Flag Coverage Δ
Linux_1 28.21% <20.83%> (-0.01%) ⬇️
Linux_2 56.35% <78.57%> (+<0.01%) ⬆️
Linux_3 37.41% <12.50%> (-0.01%) ⬇️
Linux_4 29.72% <12.50%> (-0.01%) ⬇️
Windows_1 28.23% <20.83%> (-0.01%) ⬇️
Windows_2 56.31% <78.57%> (+<0.01%) ⬆️
Windows_3 37.41% <12.50%> (-0.01%) ⬇️
Windows_4 29.72% <12.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 0134eb6 into 2.17 Sep 6, 2024
66 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset v2.17.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants