Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] [Workspace] Use small button, small padding and compressed. #7842

Merged

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Aug 26, 2024

Description

Use "small" buttons, "compressed" form inputs and small padding on popovers

Issues Resolved

Screenshot

Testing the changes

Changelog

  • refactor: [Workspace] Use small button, small padding and compressed.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…povers

Signed-off-by: yubonluo <yubonluo@amazon.com>
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (452b65d) to head (78e0fd0).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7842   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files        3661     3661           
  Lines       81347    81347           
  Branches    12978    12978           
=======================================
  Hits        51926    51926           
  Misses      26235    26235           
  Partials     3186     3186           
Flag Coverage Δ
Linux_1 30.14% <100.00%> (ø)
Linux_2 55.87% <ø> (ø)
Linux_3 40.39% <ø> (ø)
Linux_4 31.34% <ø> (ø)
Windows_1 30.16% <100.00%> (ø)
Windows_2 55.82% <ø> (ø)
Windows_3 40.39% <ø> (ø)
Windows_4 31.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl added the v2.17.0 label Aug 26, 2024
@SuZhou-Joe SuZhou-Joe merged commit a5c3dc2 into opensearch-project:main Aug 26, 2024
73 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7842-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a5c3dc2ac42b8acb9bc223f38eb61b6d0ae208e8
# Push it to GitHub
git push --set-upstream origin backport/backport-7842-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7842-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7842-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a5c3dc2ac42b8acb9bc223f38eb61b6d0ae208e8
# Push it to GitHub
git push --set-upstream origin backport/backport-7842-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7842-to-2.x.

@kavilla
Copy link
Member

kavilla commented Sep 12, 2024

manual backport: #7878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants