Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add Application Page Header for Visualize Pages #7778

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b3234dd from #7712.

* Add Application Header for Visualize

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Fix Application Header Layout for Discover

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR #7712 created/updated

* Add new Page Header in Vis Builder

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b3234dd)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 8.69565% with 42 lines in your changes missing coverage. Please review.

Project coverage is 63.85%. Comparing base (3835fc2) to head (8fb92c8).
Report is 5 commits behind head on 2.x.

Files Patch % Lines
...er/public/application/utils/get_top_nav_config.tsx 14.28% 18 Missing ⚠️
...components/dashboard_listing/dashboard_listing.tsx 0.00% 10 Missing ⚠️
src/plugins/vis_builder/public/application/app.tsx 0.00% 6 Missing ⚠️
..._builder/public/application/components/top_nav.tsx 0.00% 4 Missing ⚠️
.../data_explorer/public/components/app_container.tsx 33.33% 2 Missing ⚠️
...s_react/public/table_list_view/table_list_view.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7778      +/-   ##
==========================================
- Coverage   63.87%   63.85%   -0.02%     
==========================================
  Files        3655     3655              
  Lines       81045    81076      +31     
  Branches    12894    12904      +10     
==========================================
+ Hits        51769    51774       +5     
+ Misses      26153    26134      -19     
- Partials     3123     3168      +45     
Flag Coverage Δ
Linux_1 30.09% <6.97%> (-0.02%) ⬇️
Linux_2 55.95% <ø> (ø)
Linux_3 40.52% <6.66%> (-0.01%) ⬇️
Linux_4 31.46% <0.00%> (-0.01%) ⬇️
Windows_1 30.11% <6.97%> (-0.02%) ⬇️
Windows_2 55.91% <ø> (ø)
Windows_3 40.52% <6.66%> (-0.01%) ⬇️
Windows_4 31.46% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDrago27 LDrago27 merged commit 63723a5 into 2.x Aug 21, 2024
67 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset look & feel Look and Feel Improvements seasoned-contributor v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants