[Look & Feel] Appearance Popover Button Change #7777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to SheyGao/OpenSearch-Dashboards
that referenced
this pull request
Aug 20, 2024
Signed-off-by: Shey Gao <sheygao@amazon.com>
SheyGao
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7777 +/- ##
==========================================
- Coverage 63.83% 63.82% -0.01%
==========================================
Files 3655 3655
Lines 81126 81126
Branches 12923 12923
==========================================
- Hits 51783 51781 -2
- Misses 26165 26166 +1
- Partials 3178 3179 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LDrago27
approved these changes
Aug 21, 2024
ananzh
approved these changes
Aug 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* dropped the primary button for apply Signed-off-by: Shey Gao <sheygao@amazon.com> * Changeset file for PR #7777 created/updated --------- Signed-off-by: Shey Gao <sheygao@amazon.com> Co-authored-by: Shey Gao <sheygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b4ae264) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
that referenced
this pull request
Aug 21, 2024
* dropped the primary button for apply * Changeset file for PR #7777 created/updated --------- (cherry picked from commit b4ae264) Signed-off-by: Shey Gao <sheygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shey Gao <sheygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Apply button to align with the guideline of "using primary buttons exclusively for primary calls to action."
Screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration