-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Look&Feel] Discover and Query Management fix #7558
Conversation
* Removed downArrow icon and tooltip Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changed icons from smallIcons to xs Signed-off-by: Dan Dong <danieldong51@gmail.com> * Added browser tooltip back Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changed remove field icon size to xs Signed-off-by: Dan Dong <danieldong51@gmail.com> * Changeset file for PR #7530 created/updated * Changed positioning attributes to ToolTip Anchor Signed-off-by: Dan Dong <danieldong51@gmail.com> (cherry picked from commit 5dbce93) * Updated snapshot testing Signed-off-by: Dan Dong <danieldong51@gmail.com> --------- Signed-off-by: Dan Dong <danieldong51@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 7073999) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7558 +/- ##
==========================================
+ Coverage 63.74% 63.76% +0.01%
==========================================
Files 3628 3628
Lines 79498 79498
Branches 12590 12590
==========================================
+ Hits 50676 50688 +12
+ Misses 25759 25748 -11
+ Partials 3063 3062 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine, retriggered ci to see if we could get them to pass, but failures are unrelated
Merging, one of the |
Backport 7073999 from #7530.