Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport][2.x][Workspace] [Data Source] feat: support workspace level default data source #7281

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

raintygao
Copy link
Contributor

@raintygao raintygao commented Jul 17, 2024

Description

Manual backport #7188

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…source (opensearch-project#7188)

* feat: support set default ds in workspace

Signed-off-by: tygao <tygao@amazon.com>

* add updateWorkspaceState

Signed-off-by: tygao <tygao@amazon.com>

* Changeset file for PR opensearch-project#7188 created/updated

* update workspace plugin test

Signed-off-by: tygao <tygao@amazon.com>

* add reset workspace state and update tests

Signed-off-by: tygao <tygao@amazon.com>

* update and add tests for workspace client

Signed-off-by: tygao <tygao@amazon.com>

* clear default data source if no data source left and seperate wrapper

Signed-off-by: tygao <tygao@amazon.com>

* add try catch and add tests

Signed-off-by: tygao <tygao@amazon.com>

* disable DSM in workspace

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: Tianyu Gao <tygao@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
(cherry picked from commit e1d5096)
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.73%. Comparing base (e751b69) to head (ef43a20).

Files Patch % Lines
src/plugins/workspace/server/utils.ts 87.50% 0 Missing and 1 partial ⚠️
src/plugins/workspace/server/workspace_client.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #7281   +/-   ##
=======================================
  Coverage   67.72%   67.73%           
=======================================
  Files        3452     3452           
  Lines       68286    68309   +23     
  Branches    11107    11113    +6     
=======================================
+ Hits        46250    46267   +17     
- Misses      19360    19363    +3     
- Partials     2676     2679    +3     
Flag Coverage Δ
Linux_1 33.32% <92.00%> (+0.03%) ⬆️
Linux_2 55.42% <ø> (ø)
Linux_3 45.06% <100.00%> (ø)
Linux_4 34.85% <100.00%> (ø)
Windows_1 33.34% <92.00%> (+0.03%) ⬆️
Windows_2 55.37% <ø> (ø)
Windows_3 45.06% <100.00%> (+<0.01%) ⬆️
Windows_4 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-project opensearch-project deleted a comment from github-actions bot Jul 17, 2024
@SuZhou-Joe SuZhou-Joe merged commit 42140ca into opensearch-project:2.x Jul 17, 2024
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants