[Backport 2.x] [navigation-next] feat: introduce new interface for group #7135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-project#7060) * feat: introduce new interface for use case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#7060 created/updated * feat: introduce new interface for use case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: introduce new interface for use case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: introduce new interface for use case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update test snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#7060 created/updated * fix: update based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add default nav group Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: type error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: expose DEFAULT_NAV_GROUPS in src/core/public Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: export NavGroupItemInMap type Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update README Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update README Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update interface Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * refactor: move navGroup related interface into a service Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * [Navigation-Next] Add nav group enabled in chrome service(7072) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * use homepage flag Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update README Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: expose sorted navLinks Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: snapshot error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update according to comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: support parent link Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update according to comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update according to comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 5212f09)
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
SuZhou-Joe
added
Skip-Changelog
BionIT
approved these changes
Jul 1, 2024
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
github-actions
bot
removed
the
Skip-Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport 5212f09 from #7060