-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Restrict saved objects finding when workspace enabled #7125
Merged
SuZhou-Joe
merged 19 commits into
opensearch-project:main
from
wanglam:limit-data-source-permission-when-workspace-enabled
Jul 5, 2024
Merged
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
30fab0d
Limit data source saved objects finding and access when workspace ena…
wanglam 17b36b6
Remove options.workspaces drop behavior in conflict client wrapper
wanglam dadd9b7
Changeset file for PR #7125 created/updated
opensearch-changeset-bot[bot] 1d08d8c
Merge branch 'main' into limit-data-source-permission-when-workspace-…
wanglam c996790
Merge branch 'main' into limit-data-source-permission-when-workspace-…
ruanyl b54291c
Update src/plugins/workspace/server/saved_objects/workspace_saved_obj…
wanglam 899341c
Update src/plugins/workspace/server/saved_objects/workspace_saved_obj…
wanglam a197688
Remove formatFindParams
wanglam 7b491fd
Fix code format
wanglam ca51d01
Merge branch 'main' into limit-data-source-permission-when-workspace-…
wanglam a2e6c27
Fix ACLSearchParams and empty workspaces
wanglam 9bbb6a3
Refactor workspace client wrapper find
wanglam 15e131e
Remove global saved objects validation logic
wanglam eb8bc9c
Update uts and its
wanglam 8cb4cb3
Changeset file for PR #7125 created/updated
opensearch-changeset-bot[bot] 97dcde0
Remove no need changes and refactor
wanglam 12cfce7
Merge branch 'main' into limit-data-source-permission-when-workspace-…
wanglam 2b1c28b
Fix global saved objects not found
wanglam 185423f
Change saved object get to assert
wanglam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
fix: | ||
- [Workspace]Limit data source permission when workspace enabled ([#7125](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7125)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove
formatFindParams
since it's no longer used?