Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace] Capabilities service add dashboard admin flag #7103

Merged
merged 10 commits into from
Jul 2, 2024
Merged

[Workspace] Capabilities service add dashboard admin flag #7103

merged 10 commits into from
Jul 2, 2024

Conversation

yubonluo
Copy link
Contributor

Description

Capabilities service add dashboard admin flag

Issues Resolved

#7102

Screenshot

Testing the changes

  1. Clone the latest osd/security-dashboard plugin code and run yarn osd bootstrap
  2. Modify config/opensearch_dashboards.yml
opensearchDashboards.dashboardAdmin.groups: ["dashboard_admin"]
opensearchDashboards.dashboardAdmin.users: ["username"]
workspace.enabled: true 
opensearch.username: "username"
opensearch.password: "password" 
opensearch.ssl.verificationMode: none
savedObjects.permission.enabled: true
  1. Run yarn start --no-base-path

Changelog

  • feat: [Workspace] Capabilities service add dashboard admin flag

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yubonluo
Capabilities service add dashboard admin flag
d6c9b10 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@yubonluo
Capabilities service add dashboard admin flag
72a7615 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.49%. Comparing base (9ac3184) to head (ca0957e).
Report is 358 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7103   +/-   ##
=======================================
  Coverage   67.49%   67.49%           
=======================================
  Files        3468     3468           
  Lines       68363    68366    +3     
  Branches    11110    11110           
=======================================
+ Hits        46140    46143    +3     
  Misses      19523    19523           
  Partials     2700     2700
Flag Coverage Δ
Linux_1 33.05% <100.00%> (+<0.01%) ⬆️
Linux_2 55.18% <ø> (ø)
Linux_3 45.35% <ø> (-0.02%) ⬇️
Linux_4 34.77% <ø> (ø)
Windows_1 33.07% <100.00%> (+<0.01%) ⬆️
Windows_2 55.14% <ø> (ø)
Windows_3 45.36% <ø> (ø)
Windows_4 34.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yubonluo
optimize the code
8ba92dd 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@yubonluo
optimize the code
2ac7e63 
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
SuZhou-Joe previously approved these changes Jun 26, 2024
View reviewed changes
@yubonluo
optimize the code
3f08191 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@yubonluo
Merge branch 'main' of github.com:opensearch-project/OpenSearch-Dashb…
9b6207b 
…oards into 2.16-osd-admin
@yubonluo yubonluo requested a review from LDrago27 as a code owner June 27, 2024 01:50
ruanyl
ruanyl reviewed Jul 2, 2024
View reviewed changes
src/plugins/workspace/server/plugin.ts Outdated Show resolved Hide resolved
src/plugins/workspace/server/plugin.ts Outdated Show resolved Hide resolved
@yubonluo
optimize the code
ca0957e 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit bb9eeef into opensearch-project:main Jul 2, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 2, 2024
@github-actions @opensearch-changeset-bot
[Workspace] Capabilities service add dashboard admin flag (#7103)
52f3513 
* Capabilities service add dashboard admin flag

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Capabilities service add dashboard admin flag

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7103 created/updated

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* if groups/users are not configured or [], login defaults to OSD Admin

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit bb9eeef)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 2, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Jul 3, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace] Capabilities service add dashboard admin flag (#7103) (#7151
6a871ce 
)

* Capabilities service add dashboard admin flag



* Capabilities service add dashboard admin flag



* Changeset file for PR #7103 created/updated

* optimize the code



* optimize the code



* if groups/users are not configured or [], login defaults to OSD Admin



* optimize the code



---------



(cherry picked from commit bb9eeef)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla left review comments

@ruanyl ruanyl ruanyl approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

Assignees
No one assigned
Labels
backport 2.x in-next v2.16.0 valued-contributor workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yubonluo @ruanyl @kavilla @SuZhou-Joe @AMoo-Miki