Fix add filter for numeric scripted field

[abbyhu2000]

Description

Fix add filter for numeric scripted field. Previously, adding filters for scripted numeric fields using is operator after clicking the Add Filter Button does not produce any result.

Issues Resolved

resolves #6996

Screenshot

Screen.Recording.2024-06-13.at.12.42.54.PM.mov

Changelog

• fix: Fix add filter for numeric scripted field

[codecov]

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.12%. Comparing base (83317a2) to head (a49d0d4).
Report is 2 commits behind head on main.

Files	Patch %	Lines
...c/ui/filter_bar/filter_editor/value_input_type.tsx	14.28%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7022      +/-   ##
==========================================
- Coverage   64.13%   64.12%   -0.01%     
==========================================
  Files        3614     3615       +1     
  Lines       78689    78725      +36     
  Branches    12437    12446       +9     
==========================================
+ Hits        50465    50486      +21     
- Misses      25173    25186      +13     
- Partials     3051     3053       +2     

Flag	Coverage Δ
Linux_1	30.90% <ø> (ø)
Linux_2	55.59% <ø> (ø)
Linux_3	40.64% <14.28%> (+0.01%)	⬆️
Linux_4	31.77% <ø> (ø)
Windows_1	30.92% <ø> (ø)
Windows_2	55.54% <ø> (ø)
Windows_3	40.65% <14.28%> (+<0.01%)	⬆️
Windows_4	31.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[virajsanghvi]

nit: instead of using a nested ternary extract part of it out, use an if/else statement, or use parens in the nested ternary to make it easier to read.

[abbyhu2000]

Changed to if else statement

[ashwin-pc]

Can we not use snapshot tests here? Taking a look at the snapshot and they dont offer much value here

[abbyhu2000]

I think they do provide values, the unit tests are mainly testing if switch (this.props.type) are rendering correct components based on the input type. For example, string type should render with correct placeholder, boolean type should render with correct selections.

switch (this.props.type) {
      case 'string':
        inputElement = (
          <EuiFieldText
           ...
          />
        );
        break;
      case 'number':
        inputElement = (
          <EuiFieldNumber
            ...
          />
        );
        break;
      case 'date':
        inputElement = (
          <EuiFieldText
            ...
          />
        );
        break;
      case 'ip':
        inputElement = (
          <EuiFieldText
           ...
          />
        );
        break;
      case 'boolean':
        inputElement = (
          <EuiSelect
            fullWidth={this.props.fullWidth}
            options={[...]}
            ...
          />
        );

[ashwin-pc]

i meant can we just snapshot the value we expect instead of the whole thing. If this test breaks, it should be only because of the changes related to what you are testing. Right now, if the component chnages, these tests will break too. Keep unit tests scoped to just test for just the feature and not anything else. Otherwise when things change, a lot of these test will break.

[ashwin-pc]

Thanks for making the change. This looks good to me