[Backport 2.x] [Workspace] Dashboard admin(groups/users) implementation #6829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* [Workspace] dashboard admin(groups/users) implementation and integrating with dynamic application config Signed-off-by: yubonluo <yubonluo@amazon.com> * Modify change log Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * modify change log Signed-off-by: yubonluo <yubonluo@amazon.com> * modify change log Signed-off-by: yubonluo <yubonluo@amazon.com> * solve change log issue Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #6554 created/updated * [Workspace] delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #6554 created/updated * delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * Optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> * Add unit test to cover setupPermission in plugin. Signed-off-by: yubonluo <yubonluo@amazon.com> * delete the logic of dynamic application config Signed-off-by: yubonluo <yubonluo@amazon.com> * Default to OSD admin if security uninstall Signed-off-by: yubonluo <yubonluo@amazon.com> * Default to OSD admin if security uninstall Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit b839da1) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6829 +/- ##
==========================================
+ Coverage 67.60% 67.61% +0.01%
==========================================
Files 3427 3427
Lines 67357 67383 +26
Branches 10983 10990 +7
==========================================
+ Hits 45535 45561 +26
- Misses 19157 19203 +46
+ Partials 2665 2619 -46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
May 27, 2024
ruanyl
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport b839da1 from #6554.