-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fixes for Vis Builder #6811
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6811 +/- ##
==========================================
+ Coverage 67.55% 67.57% +0.02%
==========================================
Files 3428 3428
Lines 67340 67343 +3
Branches 10994 10996 +2
==========================================
+ Hits 45492 45508 +16
+ Misses 19178 19165 -13
Partials 2670 2670
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/plugins/vis_builder/public/application/components/workspace.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as pretty sure cloning was due to object inequality + tests will come separately
@@ -0,0 +1,2 @@ | |||
fix: | |||
- Bug Fixes for Vis Builder ([#6811](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6811)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: specify which bugs were fixed. We can have two entries here :)
@LDrago27 can you link the test here? |
@ashwin-pc @virajsanghvi Please find the associated functional tests corresponding to above bugs opensearch-project/opensearch-dashboards-functional-test#1340 |
* Bug Fixes for Vis Builder * Changeset file for PR #6811 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 766a39a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Bug Fixes for Vis Builder * Changeset file for PR opensearch-project#6811 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* Bug Fixes for Vis Builder * Changeset file for PR #6811 created/updated --------- (cherry picked from commit 766a39a) Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This aims to fix the following Bugs in Vis builder.
Issues Resolved
Testing the changes
Follow the steps mentioned in the above issues to check the expected behaviour.
Meeting.Recording.-.Sahoo.Suchit.Instant.Meeting.mp4
Changelog
Check List
yarn test:jest
yarn test:jest_integration