Bug Fixes for Vis Builder #6811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDrago27
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
opensearch-changeset-bot bot
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
May 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6811 +/- ##
==========================================
+ Coverage 67.55% 67.57% +0.02%
==========================================
Files 3428 3428
Lines 67340 67343 +3
Branches 10994 10996 +2
==========================================
+ Hits 45492 45508 +16
+ Misses 19178 19165 -13
Partials 2670 2670
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/plugins/vis_builder/public/application/components/workspace.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
virajsanghvi
approved these changes
May 23, 2024
ashwin-pc
approved these changes
May 24, 2024
| @@ -0,0 +1,2 @@ | |||
| fix: | |||
| - Bug Fixes for Vis Builder ([#6811](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6811)) | |||
There was a problem hiding this comment.
Nit: specify which bugs were fixed. We can have two entries here :)
|
@LDrago27 can you link the test here? |
1 task
|
@ashwin-pc @virajsanghvi Please find the associated functional tests corresponding to above bugs opensearch-project/opensearch-dashboards-functional-test#1340 |
ananzh
approved these changes
Jun 3, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Bug Fixes for Vis Builder * Changeset file for PR #6811 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 766a39a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jun 3, 2024
* Bug Fixes for Vis Builder * Changeset file for PR opensearch-project#6811 created/updated --------- Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
BionIT
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Bug Fixes for Vis Builder * Changeset file for PR #6811 created/updated --------- (cherry picked from commit 766a39a) Signed-off-by: Suchit Sahoo <suchsah@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This was referenced Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This aims to fix the following Bugs in Vis builder.
Issues Resolved
Testing the changes
Follow the steps mentioned in the above issues to check the expected behaviour.
Meeting.Recording.-.Sahoo.Suchit.Instant.Meeting.mp4
Changelog
Check List
yarn test:jestyarn test:jest_integration